yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix some exceptions being logged the wrong way (#9693)

Browse Source 
In these statements, the exception was passed as a log message parameter instead of as the exception. This meant the exception and including stack trace was not logged and thus lost.
This commit is contained in:
rbottema
2021-02-21 11:03:28 +01:00
committed by GitHub
parent 75ee3b9622
commit e554ef0445
4 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Umbraco.ModelsBuilder.Embedded/LiveModelsProvider.cs
View File

@@ -91,7 +91,7 @@ namespace Umbraco.ModelsBuilder.Embedded
catch (Exception e)
{
_mbErrors.Report("Failed to build Live models.", e);
_logger.Error<LiveModelsProvider>("Failed to generate models.", e);
_logger.Error<LiveModelsProvider>(e, "Failed to generate models.");
}
finally
{

2
src/Umbraco.ModelsBuilder.Embedded/PureLiveModelFactory.cs
View File

@@ -308,7 +308,7 @@ namespace Umbraco.ModelsBuilder.Embedded
{
try
{
_logger.Error<PureLiveModelFactory>("Failed to build models.", e);
_logger.Error<PureLiveModelFactory>(e, "Failed to build models.");
_logger.Warn<PureLiveModelFactory>("Running without models."); // be explicit
_errors.Report("Failed to build PureLive models.", e);
}

4
src/Umbraco.Web/PropertyEditors/MultiUrlPickerValueEditor.cs
View File

@@ -115,7 +115,7 @@ namespace Umbraco.Web.PropertyEditors
}
catch (Exception ex)
{
_logger.Error<MultiUrlPickerValueEditor>("Error getting links", ex);
_logger.Error<MultiUrlPickerValueEditor>(ex, "Error getting links");
}
return base.ToEditor(property, dataTypeService, culture, segment);
@@ -151,7 +151,7 @@ namespace Umbraco.Web.PropertyEditors
}
catch (Exception ex)
{
_logger.Error<MultiUrlPickerValueEditor>("Error saving links", ex);
_logger.Error<MultiUrlPickerValueEditor>(ex, "Error saving links");
}
return base.FromEditor(editorValue, currentValue);

4
src/Umbraco.Web/UmbracoInjectedModule.cs
View File

@@ -328,7 +328,7 @@ namespace Umbraco.Web
}
catch (Exception ex)
{
_logger.Error<UmbracoModule>("Could not dispose item with key " + k, ex);
_logger.Error<UmbracoModule>(ex, "Could not dispose item with key {Key}", k);
}
try
{
@@ -336,7 +336,7 @@ namespace Umbraco.Web
}
catch (Exception ex)
{
_logger.Error<UmbracoModule>("Could not dispose item key " + k, ex);
_logger.Error<UmbracoModule>(ex, "Could not dispose item key {Key}", k);
}
}
}