yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

prevent changing alias of groups from other parents when typing names

Browse Source
This commit is contained in:
Niels Lyngsø
2021-07-19 15:14:01 +02:00
parent 481b4daced
commit f10e0872d5
1 changed files with 15 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/Umbraco.Web.UI.Client/src/common/directives/components/umbgroupsbuilder.directive.js
View File

@@ -113,7 +113,7 @@
// Update aliases
const parentAlias = scope.openTabAlias,
oldAlias = group.alias,
oldAlias = group.alias || null, // null when group comes from root aka. 'generic'
newAlias = contentEditingHelper.updateParentAlias(oldAlias, parentAlias);
group.alias = newAlias;
group.parentAlias = parentAlias;
@@ -500,20 +500,31 @@
};
scope.onChangeTabName = function (tab) {
updateGroupAlias(tab)
scope.openTabAlias = tab.alias;
scope.$broadcast('umbOverflowChecker.checkOverflow');
if (updateGroupAlias(tab)) {
scope.openTabAlias = tab.alias;
scope.$broadcast('umbOverflowChecker.checkOverflow');
}
};
function isAliasUnique(alias) {
return scope.model.groups.find(group => group.alias === alias) ? false : true;
}
/** Universal method for updating group alias (for tabs, field-sets etc.) */
function updateGroupAlias(group) {
const localAlias = contentEditingHelper.generateLocalAlias(group.name),
oldAlias = group.alias,
newAlias = contentEditingHelper.updateLocalAlias(oldAlias, localAlias);
// Ensure unique alias, otherwise we would be transforming groups of other parents, we do not want this.
if(isAliasUnique(newAlias) === false) {
return false;
}
group.alias = newAlias;
group.parentAlias = contentEditingHelper.getParentAlias(newAlias);
updateDescendingAliases(oldAlias, newAlias);
return true;
}
function updateDescendingAliases(oldParentAlias, newParentAlias) {