yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reverse the EnablePackageValidation in tests, so it is explicity opt-in. Otherwise the generated csproj file in Benchmarks will always fail (#14004)

Browse Source
This commit is contained in:
Bjarke Berg
2023-03-24 08:40:51 +01:00
committed by GitHub
parent 21036a4c50
commit f8e5205aa7
3 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/Directory.Build.props
View File

@@ -5,8 +5,9 @@
<PropertyGroup>
<!-- TODO: Update test projects to use nullable reference types and remove this to enable nullable warnings as errors (the solution default) -->
<Nullable>annotations</Nullable>
<EnablePackageValidation>false</EnablePackageValidation>
</PropertyGroup>
<!-- Specify rule set for all test projects -->
<PropertyGroup>
<CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)codeanalysis.ruleset</CodeAnalysisRuleSet>

1
tests/Umbraco.Tests.Common/Umbraco.Tests.Common.csproj
View File

@@ -4,6 +4,7 @@
<Title>Umbraco CMS - Test tools</Title>
<Description>Contains commonly used tools to write tests for Umbraco CMS, such as various builders for content etc.</Description>
<RootNamespace>Umbraco.Cms.Tests.Common</RootNamespace>
<EnablePackageValidation>true</EnablePackageValidation>
</PropertyGroup>
<ItemGroup>

1
tests/Umbraco.Tests.Integration/Umbraco.Tests.Integration.csproj
View File

@@ -6,6 +6,7 @@
<IsPackable>true</IsPackable>
<IsTestProject>true</IsTestProject>
<RootNamespace>Umbraco.Cms.Tests.Integration</RootNamespace>
<EnablePackageValidation>true</EnablePackageValidation>
</PropertyGroup>
<ItemGroup>