yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Inverted conditional on linking user for clarity.

Browse Source
This commit is contained in:
Andy Butland
2021-11-15 11:45:00 +01:00
parent c6176a0ae7
commit fe396ba0cf
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/Umbraco.Web.BackOffice/Security/BackOfficeSignInManager.cs
View File

@@ -194,14 +194,14 @@ namespace Umbraco.Cms.Web.BackOffice.Security
}
var shouldLinkUser = autoLinkOptions.OnExternalLogin == null || autoLinkOptions.OnExternalLogin(autoLinkUser, loginInfo);
if (shouldLinkUser == false)
if (shouldLinkUser)
{
LogFailedExternalLogin(loginInfo, autoLinkUser);
return ExternalLoginSignInResult.NotAllowed;
return await LinkUser(autoLinkUser, loginInfo);
}
else
{
return await LinkUser(autoLinkUser, loginInfo);
LogFailedExternalLogin(loginInfo, autoLinkUser);
return ExternalLoginSignInResult.NotAllowed;
}
}
else
@@ -236,14 +236,14 @@ namespace Umbraco.Cms.Web.BackOffice.Security
else
{
var shouldLinkUser = autoLinkOptions.OnExternalLogin == null || autoLinkOptions.OnExternalLogin(autoLinkUser, loginInfo);
if (shouldLinkUser == false)
if (shouldLinkUser)
{
LogFailedExternalLogin(loginInfo, autoLinkUser);
return ExternalLoginSignInResult.NotAllowed;
return await LinkUser(autoLinkUser, loginInfo);
}
else
{
return await LinkUser(autoLinkUser, loginInfo);
LogFailedExternalLogin(loginInfo, autoLinkUser);
return ExternalLoginSignInResult.NotAllowed;
}
}
}