Commit Graph

42194 Commits

Author SHA1 Message Date
patrickdemooij9
31cb328c3b Use less memory when generating a GuidUdi (#13090)
* Use less memory when generating a GuidUdi

* PR feedback

Co-authored-by: Sebastiaan Janssen <sebastiaan@umbraco.com>
2022-10-04 01:49:59 +02:00
Sebastiaan Janssen
71276b7b4d Merge branch 'v10/dev' into v10/contrib 2022-10-03 13:43:27 +02:00
Nikolaj Geisle
5115af0a31 Revert "Removing X-XSS-Protection healthcheck" (#13096)
This reverts commit 696475ebf2.

Co-authored-by: Zeegaan <nge@umbraco.dk>
2022-10-03 08:37:09 +02:00
Karl Butler
bdbf9122c9 Fixes umbraco/Umbraco-CMS.Accessibility.Issues #63 and #61 2022-10-03 02:53:48 +02:00
Patrick de Mooij
97ac1ae629 Added nullability attribute to IsNullOrWhitespace 2022-10-03 00:05:18 +02:00
Bjarne Fyrstenborg
aa9a7e415e Don't use legacy icon for action delete 2022-10-02 23:18:02 +02:00
bakersbakebread
d6a1b69ead Refactor event handler away from keyup to ng-change 2022-10-02 22:09:17 +02:00
Nikolaj Geisle
8c61e9e00b Update acceptance test readme & scripts (#13078)
* Update readme to reflect the change to playwright

* Update test scripts

* update README

* update pipelines to run new script

* update package.json scripts

* dont include demo test in package.json

* Add creation of blueprint test

* Implement create test script

Co-authored-by: Zeegaan <nge@umbraco.dk>
2022-09-30 11:45:26 +02:00
patrickdemooij9
ae5a8496bb Use char instead of string for DetectJson (#13019)
* Use char instead of string for DetectJson

* Use faster method

* Change DetectIsJon method
2022-09-30 01:39:54 +02:00
Bjarne Fyrstenborg
826dbe7d62 Fix comment of view property in ConfigurationFieldAttribute (#13077)
* Fix comment of view property in `ConfigurationFieldAttribute`

* Update description of key property as well
2022-09-29 11:07:56 +02:00
Nikolaj Geisle
89f5151ddf Implement playwright acceptance tests instead of cypress (#13069)
* fix up dependencies in package.json

* Change configs to playwright

* update types

* remove cypress

* add playwright

* Fix up imports

* Move up test files

* Fix up scripts

* Update user import

* Remove allowEditInvariantFromNonDefault=True.spec.ts

* Update docker container

* Run playwright on pipelines

* Install playwright

* change urls

* change to run playwright

* Update reporter

* create .env file when installing

* update pipelines

* Remove @in yml

* Update Yaml script to use New-Item

* Pipe object to Value

* Update yaml to use "" not {}

* Update localhost to proper port

* Push package-lock.json

* include dotenv in package.json

* Add back umbraco.config.ts

* Dont change launchSettings.json

* Fix up pipelines

* Change working directory

* Add logging

* Actually name the file

* Remove .env from path

* Add working directory

* Add working directory to script

* check env content

* Update more working dir

* Try making newline in YAML

* add quotes

* Try multiline infront of script

* Move top statement

* use https

* Update to localhost 44331

* ignore https in config

* Change linux to https

* add timeouts for tests

* Fix up url for linux

* Update docker to use port 44331 -> 5000

* increase timeout

* Update yaml

* Remove Cypress references and fix URL/port mapping

* Update umbraco-linux.docker

* Generate ASP.NET HTTPS development certificate

* Enable HTTPS development certificate in Docker

* Dont run failing tests

* Update HTTPS development certificate generation

* Copy nuget.config to correct location in Docker file

* do not run flaky test

* update outputdir

* Remove flaky tests

* Update to dot reporter

* Update to json-models-builders package

* Check if results folder exists

* Remove logging

* Use bash to find folder

* Dont use junit to report

* only publish if folder exists

* Add 5 retries for CI

* search correct folder

* Remove unused json file

* Use line reporter

* Remove umbraco.config.ts

* Remove more flaky test

* Add waits so we dont bombard SQLite

* Add page as parameter

* add page as parameter

* Remove flaky macro test

Co-authored-by: Zeegaan <nge@umbraco.dk>
Co-authored-by: Ronald Barendse <ronald@barend.se>
2022-09-29 10:49:33 +02:00
Justin Neville
3d88ed7ab2 Fix issue 13023 - Cannot read properties of undefined (reading 'allowedActions') 2022-09-29 01:51:33 +02:00
Justin Neville
48269143d5 Redirect to a return URL if one is present on the querystring when logging into the back office 2022-09-29 01:09:41 +02:00
Austin Gilbert
696475ebf2 Removing X-XSS-Protection healthcheck 2022-09-28 23:55:41 +02:00
Jeavon Leopold
17101da620 Bump Smidge up to v4.1.1 2022-09-28 22:43:51 +02:00
Bjarne Fyrstenborg
0e25d06698 Use pattern matching to check if items is not JArray 2022-09-28 21:54:54 +02:00
Kenn Jacobsen
134b193c74 New backoffice - trees design (#12963)
* Refactor: Add default versioned back office route attribute

* Tree controller bases and first draft implementations for document, media and doctype

* Move tree item view models to appropriate location

* Fix missing parent

* Refactor user entity access for testability

* A bit of clean-up + handle user start nodes for items endpoint

* Implement foldersOnly for folder tree

* Items endpoint for document type tree

* Strongly typed action results

* Content + media recycle bin

* Correct return type for swagger

* Member type tree

* Rename user start node handling to make a little more sense

* Revert to faked admin start nodes in document tree

* Media type tree

* Data type tree

* Relation type tree

* Remove unused dependency from member type tree

* Correct documentation for member type tree endpoint response types

* Use icon constants

* Add templates tree

* Member group tree

* Document blueprint tree

* Partial views, scripts and stylesheets trees

* Static files tree

* Clarify "folders only" state

* Comments and improved readability

* Rename TreeControllerBase and TreeItemViewModel

* Move recycle bin controller base to its own namespace

* Moved tree base controllers to their own namespace

* Common base class for tree view models

* Remove ProblemDetails response type declaration from all actions

* Add OpenApiTag

* Various review comments

* Dictionary item tree

* Renamed all tree controllers to follow action/feature naming convention

* Handle client culture state for document tree

* Support "ignore user start nodes" for content and media + refactor how tree states work to make things more explicit

* Fix or postpone a few TODOs

* Make entity service able to paginate trashed children

* Handle sorting explicitly

* Re-apply VersionedApiBackOfficeRoute to install and upgrade controllers after merge

* Use PagedViewModel instead of PagedResult for all trees

* Explain the usage of UmbracoObjectTypes.Unknown

* Introduce and apply GetMany pattern for dictionary items

* Add a note about relation type caching

* Fix broken test build + add unit tests for new localization service methods

* Use new management API controller base

* Entity repository should build document entities for document blueprints when getting paged entities (same as it does when getting specific entities)

* Use Media type for Media recycle bin

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

* Move shared relation service to concrete implementations

* Use inclusive language

* Add 401 response type documentation to applicable trees

* Refactor entity load for folder tree controller base + ensure that folders are only included in the first result page

* Add (in-memory) pagination to dictionary tree

* Make file system controller honor paging parameters

* Support pagination in relation type tree

* Clarify method name a bit for detecting tree root path requests

* Update Open API schema to match new trees

* Move from page number and page size to skip/take (with temporary workaround for lack of property skip/take pagination in current DB implementation)

* Update OpenAPI schema to match skip/take

* Update OpenAPI schema

* Don't return paginated view models from "items" endpoints

* Update OpenApi schema

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
2022-09-28 13:37:59 +02:00
Nikolaj Geisle
3752f51625 Make Searchers endpoint return ActionResult (#13068) 2022-09-28 13:00:27 +02:00
Ronald Barendse
7890a265ab Internalize Umbraco.Cms.ManagementApi references 2022-09-27 23:43:07 +02:00
Ronald Barendse
b0ea7bc076 Add BuildProjectReferences=false to dotnet pack 2022-09-27 17:23:56 +02:00
Ronald Barendse
418db7d325 Update build script 2022-09-27 17:07:24 +02:00
Nikolaj Geisle
a0e51e3b91 New backoffice: examine management controller (#12981)
* Add ExamineManagementControllerBase

* Add ExamineIndexModelFactory

* Add IndexesExamineManagementController

* Add proper attributes

* Implement ExamineIndexViewModel.cs

* formatting

* Add comment about it working in .NET 7

* Add SearchersExamineManagementController.cs

* Update comments about why it might throw errors

* Add SearchResultViewModel

* Add SearchExamineManagementController

* Add ExamineSearcherValidationService

* Rename ExamineSearcherValidationService.cs to ExamineSearcherFinderService.cs

* Rename interface aswell

* Add SearchExamineManagementController

* Refactor ExamineSearcherFinderService

* Add HasIndexRebuiltExamineManagementController.cs

* Fix up formatting

* Async actions

* Add RebuildIndexExamineManagementController.cs

* Rename IExamineIndexModelFactory to IExamineIndexViewModelFactory

* Refactor HasIndexRebuilt endpoint to Index endpoint

* Remove unused usings

* Fix up DetailsExplanation

* Create dedicated SearchersViewModel

* Rename action

* Rename RebuildIndex to Rebuild

* Dont have changes in ExamineIndexModel

* Make values strongly typed instead of generic lists of strings

* Rename to non-plural

* Rename to non-plural

* Rename controller

* Introduce ITemporaryIndexingService

* Introduce ITemporaryIndexingService

* Add SearcherName to view model

* Move to new ExamineManagementControllerBase.cs

* Refactor ExamineManagerService

* Use init instead of setters

* Make properties explicitly on models

* Add DI

* Apply suggestions from code review

Co-authored-by: Kenn Jacobsen <kja@umbraco.dk>

* Rename to IndexExamineManagementController

* Return ViewModel instead of exception

* Make view models non-nullable

* Add examine management extension point

* Rename to IndexingRebuilderService

* Move rebuild logic to service

* Fix up usages in IIndexingRebuilderService

* Fix up DI

* Fix OpenApi contract

* Implement CanRebuild on IIndexingRebuilderService.cs

Co-authored-by: Zeegaan <nge@umbraco.dk>
Co-authored-by: Kenn Jacobsen <kja@umbraco.dk>
2022-09-27 11:30:59 +02:00
Justin Neville
90cabb5e2b Fix issue toggling boolean between true/false after Save without refreshing 2022-09-27 02:01:16 +02:00
Busra Sengul
24b338a7a3 Fixes #12972 for validating legacy member passwords (#12973)
* Fixes #12972 for validating legacy member passwords

* Removed unused variable

* removed unused variable
2022-09-27 00:37:59 +02:00
Mole
476692c4a9 Merge pull request #13061 from umbraco/merge/10.2.1
Merge/10.2.1
2022-09-26 12:54:51 +02:00
Nikolaj
e97354dff9 Merge branch 'release/10.2.1' into merge/10.2.1
# Conflicts:
#	version.json
2022-09-26 12:53:19 +02:00
Mads Rasmussen
25a20cf741 Add null check for variants in Grid Layout (#13060)
This fixes a regression from 10.2.0 where the `variants` property was removed.
2022-09-26 12:33:20 +02:00
Mads Rasmussen
a342e4747f Add null check for variants in Grid Layout (#13060)
This fixes a regression from 10.2.0 where the `variants` property was removed.
2022-09-26 12:21:08 +02:00
Mole
7493e5e1fd Add spellcheck false to password inputs (#13059) 2022-09-26 11:25:59 +02:00
Kenn Jacobsen
e1d438701b Make sure swagger tags and operations are sorted alphabetically (#13055) 2022-09-24 09:50:32 +02:00
Lucas Bach Bisgaard
4b39cfe913 Bug fix for datepicker with offset time (#12847)
* https://github.com/umbraco/Umbraco-CMS/issues/12844

* remove "X" from ng-attr

Doing the test I killed the ng-if attr. But forgot it was there doing the commit

Co-authored-by: Lucas Bach Bisgaard <lom@novicell.dk>
2022-09-23 14:36:02 +02:00
Kenn Jacobsen
c903c8a1a0 New Backoffice: Published cache controller (#13034)
* Add published cache controller (endpoints for the Published Status dashboard)

* Update OpenAPI contract for published cache endpoints

* Fix OpenApi spec

Co-authored-by: Zeegaan <nge@umbraco.dk>
2022-09-23 14:03:16 +02:00
Kenn Jacobsen
12a341f67d New endpoint for web profiling dashboard (#13038)
* Endpoint for web profiling dashboard

* Add profiling API contract
2022-09-22 13:41:26 +02:00
Nikolaj Geisle
9a9bd6e480 Missing methods from IMemberService (#13022)
* Add back methods to interface

* Add default implementations to avoid breaking changes

Co-authored-by: Zeegaan <nge@umbraco.dk>
2022-09-22 10:51:48 +02:00
Sean
b7f4f95f4b pass in parameters needed to member service (#13020) 2022-09-22 10:51:16 +02:00
Jacob Overgaard
4b25beea8b improve pip classList add/remove with no intermediary variable 2022-09-22 10:43:28 +02:00
Jacob Overgaard
3f6fc6f761 add an extra check to ensure the pips exist before adding a class to them 2022-09-22 10:43:12 +02:00
Mads Rasmussen
b9f58a7bc4 Merge pull request #13044 from umbraco/bugfix/ab22651-slider-pips
Fix regression of active pips handling with noUiSlider
2022-09-22 10:22:50 +02:00
Kenn Jacobsen
986635c8a0 UmbracoPath has been removed from the official schema store, remove temporary workaround from our schema generator as well (#13043) 2022-09-22 10:18:40 +02:00
Andy Butland
68f9a1e68c Updated project references for Forms and Deploy in the JsonSchema project. (#13047) 2022-09-22 07:53:37 +02:00
Andy Butland
4e6e0d6e14 Updated project references for Forms and Deploy in the JsonSchema project. (#13047) 2022-09-22 07:50:45 +02:00
Erik-Jan Westendorp
a95f4504eb Translate "User permissions for languages" feature to español (#12975)
* Translate 'selectLanguages' to Español

* Translate 'languagesHelp' to español

* Translate 'allowAccessToAllLanguages' to spanish
2022-09-22 01:22:34 +02:00
Erik-Jan Westendorp
2f84d3071a Translate "User permissions for languages" feature to dutch (#12971)
* Translate 'sectionsHelp' to Dutch

* Translate 'selectLanguages' to Dutch

* Transkate 'allowAccessToAllLanguages' to Dutch
2022-09-22 01:10:17 +02:00
Sebastiaan Janssen
4effe1d462 Bump version to 10.2.1 2022-09-21 16:21:57 +02:00
Bjarne Fyrstenborg
0142ade713 Ensure consistent margin on headings in tree root (#12992)
(cherry picked from commit 88bfef9e0d)
2022-09-21 16:18:55 +02:00
Bjarne Fyrstenborg
88bfef9e0d Ensure consistent margin on headings in tree root (#12992) 2022-09-21 16:10:40 +02:00
Mads Rasmussen
3139ad99e0 Only contain style instead of full layout (#13033) 2022-09-21 15:58:51 +02:00
Jacob Overgaard
348f3e71ea improve pip classList add/remove with no intermediary variable 2022-09-21 15:37:57 +02:00
Jacob Overgaard
65d065fb54 add an extra check to ensure the pips exist before adding a class to them 2022-09-21 14:59:54 +02:00
Sebastiaan Janssen
cbfeba0807 Fix CodeQL duplicate "permissions" node and reformat 2022-09-20 16:03:57 +02:00