Commit Graph

41038 Commits

Author SHA1 Message Date
Nikolaj Geisle
44ddf7acef Add extra check (#12075)
Co-authored-by: Nikolaj Geisle <niko737@edu.ucl.dk>
2022-03-02 08:47:35 +01:00
Mole
0c7ef06031 V9: Fix missing site identifier (#12040)
* Add SiteIdentifierService

* Use SiteIdentifierService in TelemetryService

* Use SiteIdentifierService when installing

* Remove timeout

* Use TryGetOrCreateSiteIdentifier in TelemetryService

* Add site identifier to dashboard url

* Fix and add tests

* Don't accept empty guid as valid site identifier

* Fix dashboard controller

* Fix site id query parameter

* Use Optionsmonitor onchange

Co-authored-by: nikolajlauridsen <nel@umbraco.dk>
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
2022-02-28 13:59:39 +01:00
Paul Johnson
4a6c409a1f Explicitly close release signal file. (#12057) 2022-02-25 10:56:45 +00:00
Paul Johnson
4351ce6ee4 Further changes requested during review of #12049 (#12053) 2022-02-25 08:22:37 +00:00
Paul Johnson
de4b3af28f Resolve various points related to deficiencies in FileSystemMainDomLock (#12052)
* Resolve various points related to deficiencies in FileSystemMainDomLock

See GH #12049

* Increasing backoff time for retry when deleting lock release signal file
However reducing max tries, really hoping this never actually happens
and if it does, failing to boot ASAP seems reasonable.
2022-02-24 14:38:33 +00:00
Bjarke Berg
321d5b49bd Fix docfx namespace (#12048)
* Temp hack for building docs on pr

* Fix namespace

* revert hack to build docs on pr
2022-02-24 12:40:06 +01:00
Bjarke Berg
366d7c0fce Update docfx dependency (#12046)
* Update docfx

* temp commit to test out azure pipeline

* Rollback temp fix
2022-02-24 11:30:20 +01:00
Paul Johnson
860c8e8ae2 Filesystem based MainDomLock & extract interface for MainDomKey generation (#12037)
* Extract MainDomKey generation to its own class to ease customization.

Also add discriminator config value to GlobalSettings for advanced users.
Prevents a mandatory custom implementation, should be good enough for
the vast majority of use cases.

* Prevent duplicate runs of ScheduledPublishing during slot swap.

* Add filesystem based MainDomLock
2022-02-24 10:17:34 +00:00
Nikolaj Geisle
dafd7f298d Merge pull request #12024 from umbraco/v9/feature/add_user_group_tests
Add user group tests
2022-02-22 10:48:40 +01:00
Paul Johnson
e67da0b198 Ignore certificate errors for KeepAlive task. (#12019) 2022-02-22 09:49:56 +01:00
Mole
4f0a837e20 V9: Fix login timeout (#12029)
* Turn SlidingExpiration off and only renew cookie of not RemainingSeconds request

Also adds the TicketExpiresClaim before validating the the security stamp, otherwise the claim won't be merged and "dissappear", leading to the user being instantly logged out

Also only EnsureValidSessionId if not RemainingSeconds request, otherwise the session will always be valid, since the remaining seconds request renews it.

* Don't ignore SessionIdClaimType and Cookiepath when merging claims

Besides what the comment used to state these claims are only issued when logging in, leading you to be logged out once the claims are merged, furthermore when we check the session ID we verify that you session has not expired.

* Manually specify Issued and Expires when renewing token

If we don't we lose 30 minutes of our ExpireTimeSpan every time the principal refreshes

* Re-add ignored claims

And use MergeAllClaims on refreshing principal instead.

* EnsureValidSessionId before updating IssuedUtc

* Fix comment

* Update src/Umbraco.Web.BackOffice/Security/ConfigureBackOfficeCookieOptions.cs

Co-authored-by: nikolajlauridsen <nel@umbraco.dk>
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
2022-02-22 08:29:27 +01:00
Sebastiaan Janssen
ab870347ed Merge branch 'v9/dev' into v9/contrib
# Conflicts:
#	src/Umbraco.Web.UI.Client/src/less/pages/login.less
2022-02-21 10:06:08 +01:00
Robert Foster
06f2408ebc Fix for #11977 - Content Name auto-numbering correction (#11996) 2022-02-21 10:20:08 +10:00
Mark Drake
a53d28310f new stick top position for rte toolbar if tabs are present, issue #11870 2022-02-21 10:19:10 +10:00
Lantzify
9568d0cd6d Added name & color description for umbAvatar 2022-02-21 10:02:41 +10:00
Anders Bjerner
aba5edce02 Fixed issue in umbeditorheader.directive.js examples 2022-02-21 08:25:04 +10:00
Paul Johnson
791e4f92a1 Quick fix for PrefixLocalCallsWithThis 2022-02-18 11:41:27 +00:00
Nikolaj Geisle
566648de3f Add user group tests 2022-02-18 09:26:47 +01:00
Mole
a13e66d559 Merge branch 'v9/9.3' into v9/dev
# Conflicts:
#	build/templates/UmbracoPackage/.template.config/template.json
#	build/templates/UmbracoProject/.template.config/template.json
#	src/Directory.Build.props
2022-02-17 15:09:55 +01:00
Bjarke Berg
3a269ed329 Fix issue with migration from 8 and added support for 8.18 migration (#12020)
* Fixed issue with migration from 8, because the external login table is changed in 9.3, but added in 9.0. we need to use the legacy models when running 9.0 migrations

* Support migration from 8.18 (final state)
2022-02-17 15:06:25 +01:00
Ronald Barendse
7f762df952 Fix DataValueEditor incorrectly serializing JSON value (#12015)
* Remove JSON serialization

* Skip JSON serialization of strings
2022-02-17 13:34:48 +01:00
Ronald Barendse
27a3431e76 Fix DataValueEditor incorrectly serializing JSON value (#12015)
* Remove JSON serialization

* Skip JSON serialization of strings
2022-02-17 13:33:45 +01:00
Mole
7cc495dc65 Bump version to 9.3.1 2022-02-17 13:20:53 +01:00
Bjarke Berg
b581a45e05 Fix for rooted UNC paths (#11982) 2022-02-17 13:17:53 +01:00
Bjarke Berg
76fc3f8201 Fix for rooted UNC paths (#11982) 2022-02-17 10:59:35 +00:00
Matt Brailsford
555b4fadf1 Lookup plugin lang / icons folders in a case insensitive way (#11985)
* Use lowercase lang folder name for packages lang files

Use lowercase lang folder name for packages lang files to be consistent with Umbraco's casing

* Case insensitive `lang` folder lookup

* Comment grammar

* Setup lower case appl_plugin icons folder path

* Update Constants-SystemDirectories.cs

* Check both casings for the AppPluginIcons path

* Fixed spelling mistake + avoid multiple Exists checks

* Add IsCaseSensitiveFileSystem to IHostingEnvironment

* Add IsCaseSensitiveFileSystem to AspNetCoreHostingEnvironment

* Undo last changes

* Undo last changed

* Add FileSystemUtility

* Only perform second iconPath if OS is case sensitive

* Undo changes

* Undo changes

* Remove filesystem utils file

* Added HostingEnvironmentExtensions.cs

* Use IsCaseSensitiveFileSystem extension method

* Use the Umbraco.Extensions namespace

* Simplify IsCaseSensitiveFileSystem

* Better naming

* Use PluginIcons

* Remove unused using statement

* Delete HostingEnvironmentExtensions.cs

* Update IconService.cs

* Comment clarity

* Update src/Umbraco.Infrastructure/DependencyInjection/UmbracoBuilder.Services.cs

Co-authored-by: Paul Johnson <pmj+github@ologn.co.uk>

Co-authored-by: Paul Johnson <pmj+github@ologn.co.uk>
Co-authored-by: Michael Latouche <michael@crossingpaths.be>
2022-02-17 00:04:41 +01:00
Søren Kottal
79817f5463 Makes group name wider to fit long group names 2022-02-16 02:20:21 +01:00
Lantzify
ff6a8d781d UmbEditorHeaders hide-icon on "true" 2022-02-16 09:43:43 +10:00
Bjarne Fyrstenborg
789a908a31 Adjust z-index of notifications (#11634)
* Store notification z-index in variable

* Only show unordered list if any notifications

* Move notificaion layers to same parent as overlays so layers can be controlled via z-index
2022-02-16 09:27:13 +10:00
Søren Kottal
336f2c2d5b Makes the template column i NC config expandable 2022-02-16 09:17:59 +10:00
Jeavon
8b6c844a55 Exclude the Umbraco Log files from UmbracoProject template gitignore 2022-02-16 07:57:06 +10:00
Ronald Barendse
f1c83fbd80 Only select ItemIdFieldName in PublishedContentQuery.Search to improve performance (#11950)
* Fix code styling

* Only select ItemIdFieldName and fix exception when variation context is null

* Save hashset instead of making on on each request (indirectly)

Co-authored-by: Bjarke Berg <mail@bergmania.dk>
2022-02-15 16:46:20 +01:00
Bjarke Berg
0f4020dc7b Merge remote-tracking branch 'origin/v8/dev' into v9/dev
# Conflicts:
#	build/NuSpecs/UmbracoCms.Web.nuspec
#	src/SolutionInfo.cs
#	src/Umbraco.Core/Configuration/UmbracoSettings/ContentElement.cs
#	src/Umbraco.Core/Configuration/UmbracoSettings/IContentSection.cs
#	src/Umbraco.Examine/Umbraco.Examine.csproj
#	src/Umbraco.Tests/Umbraco.Tests.csproj
#	src/Umbraco.Web.UI.Client/src/assets/img/application/umbraco_logo_large_blue.svg
#	src/Umbraco.Web.UI.Client/src/assets/img/application/umbraco_logomark_white.svg
#	src/Umbraco.Web.UI.Client/src/common/directives/components/application/umbappheader.directive.js
#	src/Umbraco.Web.UI.Client/src/less/components/application/umb-app-header.less
#	src/Umbraco.Web.UI.Client/src/views/components/application/umb-app-header.html
#	src/Umbraco.Web.UI.Client/src/views/content/content.protect.controller.js
#	src/Umbraco.Web.UI.Client/src/views/packages/views/install-local.controller.js
#	src/Umbraco.Web.UI.Client/src/views/packages/views/install-local.html
#	src/Umbraco.Web/Editors/BackOfficeServerVariables.cs
#	src/Umbraco.Web/Umbraco.Web.csproj
2022-02-15 14:10:17 +01:00
Bjarke Berg
62fa1695df Add config to hide backoffice logo (#11999)
* Added config to hide backoffice logo

* rename to hideBackofficeLogo

* hide on mobile

* add hideBackofficeLogo

* implement hideBackofficeLogo + toggle on click

* Updated c# syntax

Co-authored-by: Niels Lyngsø <niels.lyngso@gmail.com>
2022-02-15 10:48:52 +01:00
Andy Butland
de2668a621 Added section for promoted packages in the back-office. (#11947)
* Added section for promoted packages in the back-office.

* Updates from PR review.
2022-02-14 17:41:12 +01:00
Paul Johnson
a34e278a40 Fix whitespace in sln 2022-02-14 14:46:37 +00:00
Paul Johnson
461043bd82 Change web projects TargetFrameworkMoniker to 4.5.2 to stop VS 2022 err 2022-02-14 14:43:33 +00:00
Sebastiaan Janssen
7f9b143e1a Fix items found in PVS-Studio analysis 2022-02-14 08:08:42 +10:00
Paul Johnson
91c4c77676 Switch a lot of warnings to suggestions until we are able to resolve. (#11974)
* Switch a lot of warnings to suggestions until we are able to resolve.

* Make stylecop respect more csharp_style rules

e.g. csharp_using_directive_placement

* Added cheatsheet

* Drop sorting requirements for using directives.
2022-02-11 16:24:53 +00:00
Erik-Jan Westendorp
d1f1817744 Translate "Create dictionary item" to Dutch 2022-02-11 08:43:34 +10:00
Paul Johnson
8393a5ba04 Merge pull request #11952 from mattbrailsford/patch-7
Don't hold static UmbracoContext reference
2022-02-10 18:10:01 +00:00
Paul Johnson
cf410ab91e Attempt to make app local icu setup less problematic. (#11961)
* Attempt to make app local icu setup less problematic.

Prevents issues for windows build agent -> linux app server.

On Windows version is split at first '.' e.g. 68.2.0.9 ->  icuuc68.dll
https://github.com/dotnet/runtime/blob/205f70e/src/libraries/System.Private.CoreLib/src/System/Globalization/GlobalizationMode.Windows.cs

On Linux we are looking for libicuuc.so.68.2.0.9
https://github.com/dotnet/runtime/blob/205f70e/src/libraries/System.Private.CoreLib/src/System/Globalization/GlobalizationMode.Unix.cs

On macos we don't have a native library in a shiny nuget package so hope
folks are building on their macs or setting the rid until we have a
better solution.

* Combine elements
2022-02-10 12:03:35 +00:00
Ibrahim Muhammad Nada
df6c8a4ecc refactor setTitle in MediaPicker.Controller.js (#11428)
* refactor setTitle in MediaPicker.Controller.js

* adding vm.activeTab

Co-authored-by: inada <inada@2p.com.sa>
2022-02-10 09:20:18 +10:00
Bjarne Fyrstenborg
be6e0879e4 Align tags vertically in content type property component 2022-02-10 08:52:39 +10:00
Bjarne Fyrstenborg
731b06a987 Use pointer cursor pointer for keyboard shortcuts overview 2022-02-10 08:04:38 +10:00
Mark Drake
6f89bf2a45 fixes umbraco logo appearance on backoffice login page, issue #11830 (#11900)
* fixes umbraco logo appearance on backoffice login page, issue #11830

* gives umbraco logo minimum width of 30px, issue #11830
2022-02-10 08:00:57 +10:00
Callum Whyte
4eda091fdb Lookup backoffice section name in route locationTitle (#11816)
* Lookup backoffice section name in route locationTitle

* Getting original title from $rootScope
2022-02-10 07:56:59 +10:00
nikolajlauridsen
b63aa4b19c Merge remote-tracking branch 'origin/v9/9.3' into v9/dev
# Conflicts:
#	build/templates/UmbracoPackage/.template.config/template.json
#	build/templates/UmbracoProject/.template.config/template.json
#	src/Directory.Build.props
2022-02-09 13:31:49 +01:00
nikolajlauridsen
eea02137ae Bump version to non-rc 2022-02-09 10:26:31 +01:00
Bjarke Berg
3d28552a77 Add settings to bypass 2fa for external logins (#11959)
* Added settings for bypassing 2fa for external logins

* Fixed issue with saving roles using member ID before the member had an ID.

* Added missing extension method

* Removed test classes from git

* rollback csproj
2022-02-09 10:19:39 +01:00