Commit Graph

38463 Commits

Author SHA1 Message Date
Bjarke Berg
65b20572b7 V9: Resolve virtual view paths from DataEditorAttribute in DataValueEditor (#10279)
* https://github.com/umbraco/Umbraco-CMS/issues/10265
Resolve virtual view paths from DataEditorAttribute in DataValueEditor + Introduced an IDataValueEditorFactory, so we don't need to inject nested dependencies every time we introduce a new dependency in DataValueEditor..

* Cleanup + xml doc
2021-05-18 12:40:24 +02:00
Bjarke Berg
2c10fd7034 update and add mock 2021-05-18 11:38:54 +02:00
Bjarke Berg
15e5e6b339 Remove reference to Umbraco.Tests from Umbraco.Tests.Benchmarks 2021-05-18 11:23:19 +02:00
Shannon Deminick
eba6373a12 Examine 2.0 integration (#10241)
* Init commit for examine 2.0 work, most old umb examine tests working, probably a lot that doesn't

* Gets Umbraco Examine tests passing and makes some sense out of them, fixes some underlying issues.

* Large refactor, remove TaskHelper, rename Notifications to be consistent, Gets all examine/lucene indexes building and startup ordered in the correct way, removes old files, creates new IUmbracoIndexingHandler for abstracting out all index operations for umbraco data, abstracts out IIndexRebuilder, Fixes Stack overflow with LiveModelsProvider and loading assemblies, ports some changes from v8 for startup handling with cold boots, refactors out LastSyncedFileManager

* fix up issues with rebuilding and management dashboard.

* removes old files, removes NetworkHelper, fixes LastSyncedFileManager implementation to ensure the machine name is used, fix up logging with cold boot state.

* Makes MainDom safer to use and makes PublishedSnapshotService lazily register with MainDom

* lazily acquire application id (fix unit tests)

* Fixes resource casing and missing test file

* Ensures caches when requiring internal services for PublishedSnapshotService, UseNuCache is a separate call, shouldn't be buried in AddWebComponents, was also causing issues in integration tests since nucache was being used for the Id2Key service.

* For UmbracoTestServerTestBase enable nucache services

* Fixing tests

* Fix another test

* Fixes tests, use TestHostingEnvironment, make Tests.Common use net5, remove old Lucene.Net.Contrib ref.

* Fixes up some review notes

* Fixes issue with doubly registering PublishedSnapshotService meanig there could be 2x instances of it

* Checks for parseexception when executing the query

* Use application root instead of duplicating functionality.

* Added Examine project to netcore only solution file

* Fixed casing issue with LazyLoad, that is not lowercase.

* uses cancellationToken instead of bool flag, fixes always reading lastId from the LastSyncedFileManager, fixes RecurringHostedServiceBase so that there isn't an overlapping thread for the same task type

* Fix tests

* remove legacy test project from solution file

* Fix test

Co-authored-by: Bjarke Berg <mail@bergmania.dk>
2021-05-18 10:31:38 +02:00
Andy Butland
9b7b1a7c8e Merge pull request #10275 from umbraco/v9/feature/remove-data-contract-for-deploy-base-class
Updated serialization defaults for ArtifactBase
2021-05-17 13:29:04 +02:00
Andy Butland
130be8b303 Added comment explaining use of ShouldSerialize... method in ArtifactBase. 2021-05-17 12:49:08 +02:00
Andy Butland
63670bbd34 Removed the [DataContract] attribute added on ArtifactBase in the migration from V8 to V9, which has the effect of making all properties on derived artifacts opt-in.
Handled the omission of the checksum value from the serialized string without taking a Json.Net dependency.
2021-05-17 12:09:36 +02:00
Mario Lopez
69a507e5db V9 - Include models folder in the project (#10250)
* fixes #10213. When models folder is included in project the models have a Build Action of C# Compiler

* models directory comment indicates correct models location

* added PureLive files to App_Data/Temp

* changed PureLive directory

* include generated models in project

* https://github.com/umbraco/Umbraco-CMS/pull/10250/ - Cleanup in csproj file and fix the generated template too

Co-authored-by: Mario Lopez <mario@monkii.com>
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
2021-05-17 09:50:58 +02:00
Andy Butland
0ae3a2d7ef Merge pull request #10266 from umbraco/v9/feature/further-file-service-methods
Re-implemented various file service methods from V8 required in Deploy.
2021-05-12 22:07:25 +02:00
Andy Butland
01643e494a Removed unecessary second calls to retrieve the file system in TemplateRepository. 2021-05-12 14:53:43 +02:00
Bjarke Berg
9507ba84f2 Updated version to beta003 2021-05-12 14:35:06 +02:00
Andy Butland
fd9faf5a99 Re-implemented various file service methods from V8 required in Deploy. 2021-05-12 11:58:36 +02:00
Bjarke Berg
de0929762c Fix issue with build number as part of the version 2021-05-12 09:49:41 +02:00
Bjarke Berg
a0fd6ad293 Fix issue with build number as part of the version 2021-05-12 09:41:40 +02:00
Mole
2bf86acf38 V9: Place notifications in the same namespace (#10231)
* Gather all notifications in Umbraco.Cms.Core.Notifications

* Rename notifications to match convention

* Move and rename missed notifications

* Move the three remaining public notification into Umbraco.Cms.Core.Notifications
2021-05-11 14:33:49 +02:00
Andy Butland
2e7d405687 Merge pull request #10260 from umbraco/v9/bugfix/10251-Cannot_schedule_content_when_logged_in_as_Administrator
V9: Fix issue with scheduling
2021-05-11 13:43:58 +02:00
Mole
11ca2c5d04 Merge pull request #10262 from umbraco/v9/feature/validate-credentials
Creates a method allowing validation of a user's credentials without actually logging them in.
2021-05-11 13:42:34 +02:00
Andy Butland
0a5911c1a3 Merge pull request #10248 from umbraco/v9/bugfix/fix_ordering_when_finding_views
V9: Fix search ordering of view locations
2021-05-11 13:39:39 +02:00
Bjarke Berg
9254e7883b Fixed casing issue.. 2021-05-11 12:46:03 +02:00
Bjarke Berg
fe36c80ba0 Merge remote-tracking branch 'origin/v8/dev' into v9/dev
# Conflicts:
#	src/Umbraco.Core/Cache/UserGroupCacheRefresher.cs
#	src/Umbraco.Core/Migrations/Install/DatabaseDataCreator.cs
#	src/Umbraco.Core/Persistence/Repositories/Implement/RepositoryCacheKeys.cs
#	src/Umbraco.Core/PropertyEditors/MediaPickerWithCropsValueConverter.cs
#	src/Umbraco.Core/PropertyEditors/Validators/FileExtensionConfigItem.cs
#	src/Umbraco.Core/PropertyEditors/Validators/FileUploadConfiguration.cs
#	src/Umbraco.Core/PropertyEditors/Validators/FileUploadConfigurationEditor.cs
#	src/Umbraco.Core/PropertyEditors/Validators/IFileExtensionConfig.cs
#	src/Umbraco.Core/PropertyEditors/Validators/IFileExtensionConfigItem.cs
#	src/Umbraco.Core/PropertyEditors/Validators/MediaPicker3Configuration.cs
#	src/Umbraco.Core/PropertyEditors/Validators/MediaPicker3ConfigurationEditor.cs
#	src/Umbraco.Core/PropertyEditors/Validators/MediaPicker3PropertyEditor.cs
#	src/Umbraco.Infrastructure/Cache/DefaultRepositoryCachePolicy.cs
#	src/Umbraco.Infrastructure/PropertyEditors/ValueConverters/JsonValueConverter.cs
#	src/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/Repositories/MediaTypeRepositoryTest.cs
#	src/Umbraco.Tests/Composing/TypeLoaderTests.cs
#	src/Umbraco.Tests/PublishedContent/PublishedMediaTests.cs
#	src/Umbraco.Tests/Services/MediaServiceTests.cs
#	src/Umbraco.Web.BackOffice/Controllers/MediaController.cs
#	src/Umbraco.Web.Common/Extensions/FriendlyImageCropperTemplateExtensions.cs
#	src/Umbraco.Web.UI.Client/src/views/propertyeditors/fileupload/fileupload.controller.js
#	src/Umbraco.Web.UI.NetCore/umbraco/config/lang/da.xml
#	src/Umbraco.Web.UI.NetCore/umbraco/config/lang/en.xml
#	src/Umbraco.Web.UI.NetCore/umbraco/config/lang/en_us.xml
#	src/Umbraco.Web/Cache/MemberCacheRefresher.cs
#	src/Umbraco.Web/PropertyEditors/FileUploadPropertyEditor.cs
#	src/Umbraco.Web/UrlHelperRenderExtensions.cs
2021-05-11 12:33:31 +02:00
Andy Butland
3e19824be2 Creates a method available in V8 allowing validation of a user's credentials without actually logging them in. 2021-05-11 11:29:40 +02:00
Bjarke Berg
2c665e897e https://github.com/umbraco/Umbraco-CMS/issues/10251
Fixed issue with scheduling that was not possible.
2021-05-11 08:36:31 +02:00
Niels Lyngsø
f1e2ef89d1 Merge branch 'v8/bugfix/always-ignorer-validation-when-saving' into v8/dev 2021-05-07 10:59:35 +02:00
Bjarke Berg
10341a8d62 Fix ordering of views so the ordering is the same as v8 2021-05-07 10:34:39 +02:00
Bjarne Fyrstenborg
aaa13303b2 Adjust grid editor layout configuration (#9887)
* Fix wrong end closing tag

* Add button type attribute

* Assign null instead of undefined

* Left align text in row button

* Assign temporary rows to currentLayout

* Cleanup output

* Register functions in vm

* Move nameChanged property to init function

* Don't set toggled as checked when switching columns in row

* Use existing behaviour to set allowAll

* Remove vm.layout again

* copy rows when adding new section + clean up rows on submit and close

Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
Co-authored-by: Mads Rasmussen <madsr@hey.com>
2021-05-07 10:23:19 +02:00
Andy Butland
2eb84f7d00 Merge pull request #10244 from umbraco/v9/bugfix/do-not-save-runtime_level_in_ctors
V9: Do not save runtime level in ctors
2021-05-07 08:10:22 +02:00
Bjarke Berg
145a0fabe7 Fixed issues where RuntimeState.Level was used in ctors. This is not a good idea, as these ctors are executed before the level are determined. 2021-05-07 07:40:08 +02:00
Warren Buckley
cb01e11586 Deterministic Builds for Sourcelink (#10237)
* Remove the properties from each .CSProj

* Move this into Directory.Build.props so all CSProj can get all these extra properties

* Add conditional to only add extra property to get the Deterministic green checkmark when running on Azure Pipleine
2021-05-06 19:56:43 +02:00
Warren Buckley
dabecbf7af V9 Netcore: Fix missing launch browser param for dotnet run from template (#10238)
* Adds in launchBrowser for Kestrel/Propject profile so running dotnet run from CLI will launch browser

* Keep in sync with the template file that will we ship
2021-05-06 19:56:04 +02:00
Andy Butland
6e75006f0b Merge pull request #10234 from umbraco/v9/bugfix/10232_bugfix_for_modelsbuilder_when_having_inherited_doctypes
V9: Bugfix for modelsbuilder when having inherited doctypes
2021-05-06 15:26:38 +02:00
Bjarke Berg
205c111dbc https://github.com/umbraco/Umbraco-CMS/issues/10232
Fixes issue with modelsbuilder when doctypes are inheriting from other doc types.
2021-05-06 10:58:45 +02:00
Bjarke Berg
261730f530 V9: Reintroduce missing friendly get crop url extensions (#10233)
* Adds missing extension methods of `GetCropUrl` that uses the service locator og inject the required services.

* Xml docs updated
2021-05-06 10:06:22 +02:00
Warren Buckley
0bdeda378a Merge pull request #10205 from umbraco/v9/feature/replace-system-drawing-with-imagesharp
Replaces System.Drawing with ImageSharp, and thereby fix TODO.
2021-05-05 14:57:01 +01:00
Andy Butland
811377b2e5 Fixes FileUploadCleanupFilterAttribute when incomimg model is not provided (#10162). (#10230) 2021-05-05 15:41:45 +02:00
Niels Lyngsø
6e16550b84 Dont let validation issues prevent saving (#9691)
* skipValidation for content save

* Correcting merge

* Use warning style when saving

* final corrections

* skip client side validation

* remove log

* show invariant property validation issues in the save dialog

* use warning color for .show-validation-type-warning

Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
Co-authored-by: Mads Rasmussen <madsr@hey.com>
2021-05-05 11:18:46 +02:00
Niels Lyngsø
c1dd004604 use warning color for .show-validation-type-warning 2021-05-05 11:15:23 +02:00
Niels Lyngsø
f8c38942f4 Merge remote-tracking branch 'origin/v8/dev' into v8/bugfix/always-ignorer-validation-when-saving
# Conflicts:
#	src/Umbraco.Web.UI.Client/src/common/directives/validation/valformmanager.directive.js
2021-05-05 10:37:27 +02:00
Bjarke Berg
8891edc7d5 also copy snupkg files to artifacts (symbol nuget) 2021-05-04 19:51:46 +02:00
Warren Buckley
f43f37dc35 Umbraco V9 Adds SourceLink package from Microsoft for people to debug into the relevent build commit with GitHub source code (#10224)
We had this previously in Umbraco V8
2021-05-04 18:58:50 +02:00
Niels Lyngsø
7ab09cb404 Ensure BlockObjects have references to a working current property editor. (#10195)
Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
2021-05-04 16:58:31 +02:00
Martin Amsinck Andersen
7d4a76bad4 appsettings "WebRouting:DisableRedirectUrlTracking" should be a bool not a string (#10207) 2021-05-04 13:42:31 +02:00
comstyle
8705b067c1 Update CompiledPackageXmlParser.cs (#10209)
Fix issue with hardcoded '\' as directory separator char. This caused all files in packages to be restored in the root folder with '\' in the filename on Linux.
2021-05-04 13:41:12 +02:00
Martin Amsinck Andersen
2bc1c46e57 Casing in appsettings:umbraco:cms:contentMacroErrors and using MacroErrorBehaviour Enum (#10208)
* appsettings "WebRouting:DisableRedirectUrlTracking" should be a bool not a string

* Casing in appsettings "Umbraco:CMS:Content:MacroErrors" + Using MacroErrorBehaviour enum
2021-05-04 13:40:53 +02:00
Kenn Jacobsen
b7b3eeb143 Do not change function and class names when minifying JS (#10223) 2021-05-04 13:40:35 +02:00
Niels Lyngsø
c8a98a670c Review AB11194 — Improve media selector UX (#10157)
* set input file accept

* Use PreValue file extensions for limiting the files to be chosen in file input

* Current state for Warren to review

* This should fix up what you need Niels

* update csproj

* use empty string if fileExtensions is undefined

* public interface

* initial work

* local crops

* translations

* translation correction

* fix misspeling

* some progress

* filter media picker

* align media card grid items correctly

* responsive media cropper

* always be able to scale 3 times smallest scale

* making image cropper property editor responsive

* scroll to scale

* adjust slider look

* rearrange parts of mediaentryeditor

* test helper

* styling

* move controls inside umb-image-crop

* seperate umg-cropper-gravity styling

* corrected layout

* more ui refinement

* keep the idea of mandatory out for now.

* remove double ;

* removed testing code

* JSON Property Value Convertor now has an array of property editors to exclude

* Property Value Convertor for Media Picker 3 aka Media Picker with Local Crops

* Experimenting on best approach to retrieve local crop in razor view when iterating over picked media items

* Update ValueConvertor to use ImageCropperValue as part of the model for views as alot of existing CropUrls can then use it

* Update extension methods to take an ImageCropperValue model (localCropData)

* Forgot to update CSProj for new ValueConvertor

* New GetCropUrl @Url.GetCropUrl(crop.Alias, media.LocalCrops) as oppposed to @Url.GetCropUrl(media.LocalCrops, cropAlias:crop.Alias, useCropDimensions: true)

* Remove dupe item in CSProj

* Use a contains as an opposed to Array.IndexOf

* various corrections, SingleMode based on max 1, remove double checkerBackground, enforce validation for Crops, changed error indication

* mediapicker v3

* correct version

* fixing file ext label text color

* clipboard features for MediaPicker v3

* highlight not allowed types

* highlight trashed as an error

* Media Types Video, Sound, Document and Vector Image

* Rename to Audio and VectorGraphics

* Add (SVG) in the name for Vector Graphics

* adding CSV to Documents

* remove this commented code.

* remove this commented code

* number range should not go below 0, at-least as default until we make that configurable.

* use min not ng-min

* description for local crops

* Error/Limits highlighting reactive

* visual adjustments

* Enabling opening filtered folders + corrected select hover states

* Varous fixes to resolve issues with unit tests.

* Refactor MediaType Documents to only contain Article file type

* mark as build-in

* predefined MediaPicker3 DataTypes, renaming v2 to "old"

* set scale bar current value after min and max has been set

* added missing }

* update when focal point is dragged

* adjusted styling for Image Cropper property editor

* correcting comment

* remove todo - message for trashed media items works

* Changed parameter ordering

* Introduced new extension method on MediaWithCrops to get croppings urls in with full path

* Reintroducing Single Item Mode

* use Multiple instead of SingleMode

* renaming and adding multiple to preconfigured datatypes

* Change existing media picker to use the Clipboard type MEDIA, enabling shared functionality.

* clean up unused clipboard parts

* adjusted to new amount

* correcting test

* Fix unit test

* Move MediaWithCrops to separate file and move to Core.Models

* parseContentForPaste

* clean up

* ensure crops is an array.

* actively enable focal points, so we dont set focal points that aren't used.

* only accept files that matches file extensions from Umbraco Settings

* Cleanup

* Add references from MediaPicker3 to media

* corrections from various feedback

* remove comment

* correct wording

* use windowResizeListener

* Show Media Type Selector if there is multiple types that matches the current upload batch

* clean-up and refactoring

* auto pick option

Co-authored-by: Warren Buckley <warren@umbraco.com>
Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
Co-authored-by: Mads Rasmussen <madsr@hey.com>
Co-authored-by: Andy Butland <abutland73@gmail.com>
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
Co-authored-by: Sebastiaan Janssen <sebastiaan@umbraco.com>
Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>
2021-05-04 11:06:52 +02:00
Warren Buckley
f344479b40 Netcore: dotnet new template updates and change HideTopLevelNodeFromPath default value to true (#10222)
* As we always ship with config in V8 to set this to be true makes sense it now because default in code

* Explicitly add JSON Schema property incase user IDE does not automap it

* Escaping issue with example usages
2021-05-04 11:06:25 +02:00
Niels Lyngsø
c2fd28810b show invariant property validation issues in the save dialog 2021-05-04 10:38:26 +02:00
Niels Lyngsø
ce34165e9d use formCtrl.$invalid instead of running angularHelper.countAllFormErrors, as this method is way too heavy to run in a $watch. (#10134)
Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
2021-05-03 16:18:15 +02:00
Bjarke Berg
ba2792b33e fix lowercase issue for packages 2021-05-03 15:54:25 +02:00
Niels Lyngsø
0b4be695cf Merge remote-tracking branch 'origin/v8/dev' into v8/bugfix/always-ignorer-validation-when-saving 2021-05-03 15:47:36 +02:00