yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
40,049 Commits 4 Branches 7 Tags
769f24aaae00dca885ce64d459a64a2c2eac04f2
Commit Graph

40049 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Shannon
769f24aaae Fixes reading connection strings after install 
The issue was discovered when testing Umbraco Id. If you have an existing install and there is a pending Umbraco migration (upgrade), but you clear out the connection string to force a new install screen, fill out the existing connection string details, it all works and redirects to the back office. This will throw exceptions because the runtime state is in an upgrade state (which is fixed in #11064) but if you then logout and try to log in with an active OAuth provider, it means there is a redirect outside of Umbraco and back again and you'll end up back on the installer screen - but it will not show you the upgrade screen, instead it shows you the normal install screen. This is because we are not using IOptionsMonitor for connection string settings which means it's already read the original empty connection string setting fom the very beginning and isn't reading the current/updated value.

We need to review all IOptions usages. Most of them should be IOptionsMonitor unless its impossible to change the app behavior at runtime with a particular config option.
 2021-09-09 13:15:11 -06:00
Nikolaj Geisle
dc0994a429 Merge pull request #11059 from umbraco/v9/bugfix/application-url-in-appsettings 
V9: Fix ApplicationMainUrl not being set from appsettings.json
 2021-09-09 12:39:41 +02:00
Mole
985eb1420d Merge pull request #10964 from umbraco/v9/bugfix/imagesize-cleanup 
Use ImageSharps Image.Identify for dimension extraction
 2021-09-09 12:29:17 +02:00
Nikolaj
acf0052f8e Merge branch 'v9/dev' into v9/bugfix/imagesize-cleanup 
# Conflicts:
#	src/Umbraco.Infrastructure/DependencyInjection/UmbracoBuilder.CoreServices.cs
 2021-09-09 11:40:17 +02:00
Nikolaj
7578d460c4 Assign ApplicationMainUrl in constructor of hosting environment if its specified in appsettings 2021-09-09 11:18:12 +02:00
Bjarke Berg
36582f2cd2 Merge pull request #11045 from umbraco/v9/gitignore-in-template 
Ship a gitignore in Umbraco V9 dotnet new template
 2021-09-08 21:19:35 +02:00
Warren Buckley
d797351349 Update build/templates/UmbracoProject/.gitignore 
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
 2021-09-08 20:16:07 +01:00
Bjarke Berg
97486e0705 Merge pull request #11050 from umbraco/v9/bugfix/fix-imagecropper-trygetmediapath 
Fix Image Cropper media path parsing
 2021-09-08 21:03:46 +02:00
Warren Buckley
c6c924179b Update build/templates/UmbracoProject/.gitignore 
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
 2021-09-08 19:55:56 +01:00
Bjarke Berg
2cfb099dea Merge pull request #11058 from umbraco/v9/bugfix/fix-email-handler-detection 
Fixes email handler detection
 2021-09-08 19:59:23 +02:00
Shannon
8ff78fb1de Fixes email handler detection 2021-09-08 11:19:52 -06:00
Bjarke Berg
1d55d50809 Merge pull request #11046 from umbraco/v9/feature/merge_v8.17-rc 
Merge 8.17 RC into V9, cleanup/refactor property groups/tabs API
 2021-09-08 19:17:02 +02:00
Bjarke Berg
42e27450d9 Merge pull request #11053 from umbraco/v9/bugfix/add_missing_action 
V9: Fixed missing action
 2021-09-08 19:16:47 +02:00
Bjarke Berg
3eb21d5bbd Merge pull request #11016 from umbraco/v9/feature/add_friendly_extension_method_to_replace_the_backofficeusermanager 
Added SetBackOfficeUserManager extension method to IUmbracoBuilder
 2021-09-08 19:11:52 +02:00
Bjarke Berg
a2bceb0697 Merge pull request #11002 from umbraco/v9/bugfix/fix_issues_when_changing_umbraco_path 
Bugfix: Fixed issues when changing UmbracoPath in config
 2021-09-08 19:08:11 +02:00
Bjarke Berg
e284e30df5 Fixed issues where we used the global setting UmbracoPath instead of the constant 2021-09-08 18:29:24 +02:00
Bjarke Berg
995595cce1 Merge remote-tracking branch 'origin/v9/dev' into v9/bugfix/fix_issues_when_changing_umbraco_path 2021-09-08 18:17:39 +02:00
Bjarke Berg
774a021ea5 Merge remote-tracking branch 'origin/v9/dev' into v9/dev 2021-09-08 17:50:20 +02:00
Bjarke Berg
6558ed9b0c Changes SchemeForBackOffice to just ensure it is prefixed with "Umbraco.". 
https://github.com/umbraco/UmbracoDocs/pull/3438#discussion_r703981003
 2021-09-08 17:49:56 +02:00
Bjarke Berg
e5ab0fc084 Merge pull request #10962 from umbraco/v9/task/examine-update 
Updates to latest Examine version
 2021-09-08 17:45:27 +02:00
Ronald Barendse
26c4fc339f Move extension method classes into separate files 2021-09-08 17:01:34 +02:00
Ronald Barendse
87709f7d35 Fix JS unit tests 2021-09-08 16:58:45 +02:00
Ronald Barendse
e2e9305513 Merge branch 'v8/8.17' into v9/feature/merge_v8.17-rc 2021-09-08 16:43:16 +02:00
Ronald Barendse
0aa545df75 Update parameter order of new AddPropertyGroup overload 2021-09-08 16:24:10 +02:00
Ronald Barendse
d4f3a55033 Merge pull request #11055 from umbraco/v8/bugfix/reorder-group-to-generic-tab-only-work-once 
Fix move group to Generic tab only work once
 2021-09-08 16:10:12 +02:00
Ronald Barendse
530e498132 Merge pull request #11042 from umbraco/v8/bugfix/set-correct-sort-order-on-converted-tab 
Set correct sort order on converted tab
 2021-09-08 16:09:31 +02:00
Ronald Barendse
3b994339d7 Updated directory casing for language files 2021-09-08 16:03:01 +02:00
Mads Rasmussen
05dc65ecf0 Fixes folder creation for doc, data, and media types (#11040) 
* fixes folder creation for doctype and datatype

* add fix for media types

* remove umb-auto-focus we use focus-when instead
 2021-09-08 15:58:54 +02:00
Ronald Barendse
7c250fcac7 Use ImageSharp configuration from DI (and its related ReadOrigin) 2021-09-08 15:18:29 +02:00
Mads Rasmussen
1fa816bd32 Show notification when a group can't be moved + reset requested tab 2021-09-08 15:14:12 +02:00
Ronald Barendse
9b7c43217c Move repeated code into a private method 2021-09-08 15:06:35 +02:00
Bjarke Berg
f941e9caca Fixed issue because of missing overload of GetAncestors that takes an Guid as id. 2021-09-08 14:59:52 +02:00
Nikolaj Geisle
64e958217c Merge pull request #11041 from umbraco/v9/bugfix/10641-allow-unsafe-namespace-characters-in-package-template-name 
Fixes a couple of issues with the Umbraco Package dotnet new template.
 2021-09-08 12:22:58 +02:00
Ronald Barendse
bd8d7b91d6 Support plain file path strings as Image Cropper values 2021-09-08 12:07:05 +02:00
Ronald Barendse
b145f09368 Ensure TryGetMediaPath only returns true on non-empty values 2021-09-08 12:03:56 +02:00
Elitsa Marinovska
6c56c298d6 Merge branch 'v9/dev' into v9/bugfix/fix_issues_when_changing_umbraco_path 2021-09-08 08:17:59 +02:00
Shannon Deminick
676b5c4198 Update Umbraco.Web.Common.csproj 2021-09-08 06:03:12 +10:00
Ronald Barendse
e2497d66a8 Refactor IContentTypeBase API to use property group aliases 2021-09-07 20:48:45 +02:00
Warren Buckley
b673ad2b94 Same gitignore as Umbraco Cloud team are using 2021-09-07 16:17:45 +01:00
Warren Buckley
a2a88e5851 Adds the default from dotnet new gitignore 2021-09-07 16:15:39 +01:00
Ronald Barendse
fc9c69d1fa Add 8.17.0 migration to plan 2021-09-07 16:32:24 +02:00
Ronald Barendse
02310cb3ec Change exposed PropertyGroupType enum from int to string values 2021-09-07 15:59:26 +02:00
Mads Rasmussen
f51e594929 sets sortOrder on the converted tab based on the exiting tabs 2021-09-07 14:45:44 +02:00
Ronald Barendse
8ce4993cdc Fix failing tests because of missing property group alias 2021-09-07 14:40:45 +02:00
Ronald Barendse
ee2da5b8ca Merge branch 'v8/8.17' into v9/feature/merge_v8.17-rc 2021-09-07 12:10:58 +02:00
Bjarke Berg
981982d87c Fixes https://github.com/umbraco/Umbraco-CMS/issues/10641 and a couple of other issues with the Umbraco Package dotnet new template. 
- Fixed issues with invalid namespace, when using characters like "-"
- Fixed issues with invalid characters in MSBuilder property names, like "."
 2021-09-07 10:58:33 +02:00
Nikolaj Geisle
06cf4c29b1 Merge pull request #11035 from umbraco/v9/feature/10965-allow-app-settings-configuration-of-the-Umbraco-file-sink 
Added support for configuring the UmbraocFile "sink", using IConfiguration
 2021-09-07 08:02:37 +02:00
Bjarke Berg
8e54946810 Apply suggestions from code review 
Co-authored-by: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com>
 2021-09-06 15:24:04 +02:00
Bjarke Berg
9a9f61e4c4 Merge pull request #10968 from umbraco/v9/feature/composers-cleanup 
Obsolete IUserComposer and rename Composers
 2021-09-06 14:00:59 +02:00
Bjarke Berg
47f29e3b5c Merge pull request #11034 from umbraco/bugfix/IProfileLogger.TraceDuration_does_not_work 
v9: Fixed Profilling logger to correctly send args in call
 2021-09-06 13:56:12 +02:00