Sven Geusens
9e7a36865a
Merge branch 'v13/dev' into v14/dev
...
Revert #18249 as it is reimplemented for v15
Revert #18320 as the new architecture explictly throws an error
# Conflicts:
# build/azure-pipelines.yml
# src/Umbraco.Core/EmbeddedResources/Lang/en.xml
# src/Umbraco.Core/EmbeddedResources/Lang/en_us.xml
# src/Umbraco.Core/Models/ContentEditing/ContentSaveAction.cs
# src/Umbraco.Core/Services/ContentService.cs
# src/Umbraco.Core/Services/IContentService.cs
# src/Umbraco.Core/Services/MemberService.cs
# src/Umbraco.Infrastructure/PropertyEditors/RichTextEditorPastedImages.cs
# src/Umbraco.Infrastructure/Security/BackOfficeUserStore.cs
# src/Umbraco.Infrastructure/Security/MemberUserStore.cs
# src/Umbraco.Web.BackOffice/Controllers/ContentController.cs
# src/Umbraco.Web.BackOffice/Controllers/EntityController.cs
# src/Umbraco.Web.BackOffice/Controllers/MediaController.cs
# src/Umbraco.Web.BackOffice/Controllers/MemberController.cs
# src/Umbraco.Web.BackOffice/Controllers/PreviewController.cs
# src/Umbraco.Web.BackOffice/Controllers/UsersController.cs
# src/Umbraco.Web.BackOffice/DependencyInjection/UmbracoBuilder.BackOfficeAuth.cs
# src/Umbraco.Web.BackOffice/Filters/ContentSaveValidationAttribute.cs
# src/Umbraco.Web.BackOffice/Filters/MemberSaveModelValidator.cs
# src/Umbraco.Web.BackOffice/Filters/MemberSaveValidationAttribute.cs
# src/Umbraco.Web.BackOffice/Trees/ContentTreeController.cs
# src/Umbraco.Web.Common/RuntimeMinification/SmidgeOptionsSetup.cs
# src/Umbraco.Web.Common/RuntimeMinification/SmidgeRuntimeMinifier.cs
# src/Umbraco.Web.Common/Views/UmbracoViewPage.cs
# src/Umbraco.Web.UI.Client/src/common/directives/components/buttons/umbbuttongroup.directive.js
# src/Umbraco.Web.UI.Client/src/common/directives/components/content/edit.controller.js
# src/Umbraco.Web.UI.Client/src/common/directives/components/content/umbtabbedcontent.directive.js
# src/Umbraco.Web.UI.Client/src/common/directives/components/property/umbproperty.directive.js
# src/Umbraco.Web.UI.Client/src/common/resources/content.resource.js
# src/Umbraco.Web.UI.Client/src/common/resources/publicaccess.resource.js
# src/Umbraco.Web.UI.Client/src/common/resources/users.resource.js
# src/Umbraco.Web.UI.Client/src/common/services/assets.service.js
# src/Umbraco.Web.UI.Client/src/views/common/drawers/help/help.controller.js
# src/Umbraco.Web.UI.Client/src/views/common/infiniteeditors/linkpicker/linkpicker.controller.js
# src/Umbraco.Web.UI.Client/src/views/common/infiniteeditors/mediaentryeditor/mediaentryeditor.controller.js
# src/Umbraco.Web.UI.Client/src/views/components/content/umb-tabbed-content.html
# src/Umbraco.Web.UI.Client/src/views/components/property/umb-property.html
# src/Umbraco.Web.UI.Client/src/views/content/content.create.controller.js
# src/Umbraco.Web.UI.Client/src/views/content/overlays/publishdescendants.controller.js
# src/Umbraco.Web.UI.Client/src/views/content/overlays/publishdescendants.html
# src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/listview.controller.js
# src/Umbraco.Web.UI.Client/src/views/propertyeditors/rte/rte.component.js
# src/Umbraco.Web.UI.Client/src/views/users/views/user/details.html
# src/Umbraco.Web.UI.Client/src/views/webhooks/edit.controller.js
# src/Umbraco.Web.UI.Client/src/views/webhooks/edit.html
# src/Umbraco.Web.UI.Client/test/unit/app/content/create-content-controller.spec.js
# src/Umbraco.Web.UI.Client~HEAD
# src/Umbraco.Web.UI.Login/src/auth.element.ts
# tests/Umbraco.TestData/UmbracoTestDataController.cs
# tests/Umbraco.Tests.Integration/Umbraco.Core/Services/ContentServiceTests.cs
# tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Services/ContentEventsTests.cs
# tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Services/ContentServicePublishBranchTests.cs
# tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Services/ContentServiceTagsTests.cs
# tests/Umbraco.Tests.UnitTests/Umbraco.Infrastructure/Security/MemberUserStoreTests.cs
# tests/Umbraco.Tests.UnitTests/Umbraco.Web.BackOffice/Controllers/MemberControllerUnitTests.cs
# version.json
2025-02-17 19:25:45 +01:00
Andy Butland
db1d999721
Avoid exception when attempting to find member by Id when Id is not an expected Guid or integer, as can be the case with external member providers. ( #18320 )
2025-02-17 12:47:52 +01:00
Andy Butland
18047a7cfb
Only filter post retrieval of entities for start nodes if working with entities that support start nodes. ( #18287 )
2025-02-17 12:45:51 +01:00
Andy Butland
def7ebd48c
Html encodes the user's name in the invite email. ( #18343 )
2025-02-17 12:25:12 +01:00
Nikolaj Geisle
8c2b1ebdc5
V13: Introduce publishNotifications method on IMembershipMemberService ( #18207 )
...
* Introduce publishNotifications method on IMembershipMemberService.cs
* Fix test
* Add PublishNotificationSaveOptions
* Fix up according to comments
* Use numeric values for flag enum
* Update src/Umbraco.Core/Services/MemberService.cs
Co-authored-by: Andy Butland <abutland73@gmail.com >
* Update src/Umbraco.Core/Services/MemberService.cs
Co-authored-by: Andy Butland <abutland73@gmail.com >
---------
Co-authored-by: Andy Butland <abutland73@gmail.com >
2025-02-12 13:30:41 +01:00
Andy Butland
9227517a50
Split force for publish descendants into separate options for publish unpublish and re-publish unedited (13) ( #18249 )
...
* Split force for publish descendents into separate options for publish unpublish and re-publish unedited.
* Added integration task verifying updated behaviour.
* Variant integration test.
* Update test data controller.
* Remove usued function parameters.
* Refactor to enum.
* Fixed flags enum.
* Variable name refactor.
* Applied changes from code review.
* Refactored method name.
* Aligned js boolean checks.
2025-02-12 11:30:27 +00:00
Andy Butland
5322d0f7b5
Bumped version to 13.8.0-rc.
2025-02-12 08:13:58 +01:00
Andy Butland
a282cc5691
Backport use of thread delay over sleep and handle dispose in FileSystemMainDomLock ( #18151 )
...
* Backport use of thread delay over sleep and handle dispose in FileSystemMainDomLock (from PRs #18119 and #18147 )
* Applied suggestion from code review.
2025-02-12 08:06:50 +01:00
Andy Butland
048f8bcdf9
Fixed userResource request to get all users. ( #18105 )
2025-02-11 17:06:18 +01:00
Andy Butland
7bcbc748d4
URL encodes member user names when passing information for public access setting such that those with user names as emails containing a plus will be included in the rule. ( #18142 )
2025-02-11 13:36:19 +01:00
Andy Butland
f30e6cfe7f
Prevents folder selection in media picker when used from the multi URL picker. ( #18288 )
2025-02-11 09:18:01 +01:00
Andy Butland
026e80e026
Avoid an exception on sign out when the principal is populated from an incomplete external login ( #18078 )
...
* Avoid an exception on signout when the principal is populated from an incomplete external login.
* Tidied up comment.
2025-02-10 12:51:35 +01:00
Andy Butland
a3b77cff63
Add validation to prevent update of a user or member to an invalid username (13) ( #18261 )
...
* Add validation to prevent update of a user or member to an invalid username.
* Avoid password manager updates of user name field on user details screen.
2025-02-10 10:40:53 +01:00
Niels Lyngsø
4ca68d6995
Add client-side validation for RTE ( #18257 )
2025-02-07 11:43:04 +00:00
Sven Geusens
280cb7f2b1
Fix issues in newly added buttongroup localization ( #18254 )
...
* Fix #18253 nullref exception
* Fix #18239 by listening to broader scope changes
2025-02-07 07:00:34 +01:00
jasont0101
095a73132c
Review: Allow Duplicate Email for Members ( #16202 )
...
* init
* Aligned default values on security settings.
* Added validator for security settings.
* Provide default implementation for get members by email.
* Refactored constructor of MemberController.
* Validate on unique member email only when configured to do so.
* Further code tidy and use of DI in constructor.
* Used new constructor in tests.
* Add unit test for modified behaviour.
* Removed validator for security settings (it's not necessary, I got confused with users and members).
* Spelling.
---------
Co-authored-by: Andy Butland <abutland73@gmail.com >
2025-02-05 12:38:40 +01:00
Andy Butland
cfb0fc23ac
Merge branch 'v13/dev' into v13/contrib
2025-02-04 12:35:49 +01:00
Callum Whyte
6620aca9fe
Cache null dictionary values by key ( #15576 )
...
* Add CacheNullValues option to RepositoryCachePolicy
* Cache null values in DictionaryByKeyRepository
* Fixed issue with nullable reference.
* Updated logic for caching of null values.
* Update src/Umbraco.Infrastructure/Cache/DefaultRepositoryCachePolicy.cs
Co-authored-by: Sven Geusens <geusens@gmail.com >
* Made the NullValueRepresentation overwritable in a generic manner
* Improve generic NullValueCachePolicyResolver
* Revert Commits and clarify logic with comment
This reverts commit 8befb437921cb6e3b87725cefb92a6afbf3d28fb "Improve generic NullValueCachePolicyResolver"
Also reverts 8adf0a2 - Made the NullValueRepresentation overwritable in a generic manner
And 8adf0a2 - Made the NullValueRepresentation overwritable in a generic manner
* Update src/Umbraco.Infrastructure/Cache/DefaultRepositoryCachePolicy.cs
---------
Co-authored-by: Andy Butland <abutland73@gmail.com >
Co-authored-by: Sven Geusens <geusens@gmail.com >
Co-authored-by: Sven Geusens <sge@umbraco.dk >
2025-02-04 12:29:21 +01:00
SimonHartfield
2422a02b23
Set Smidge cachebuster type ( #18198 )
...
* Set Smidge cachebuster type
* Amend exception and fix typo
* Minor tweak to comment and exception message.
---------
Co-authored-by: Simon Hartfield <simon.hartfield@googlemail.com >
Co-authored-by: Andy Butland <abutland73@gmail.com >
2025-02-04 11:00:44 +00:00
Mole
b4a9dc0770
V13: Fix members while using basic auth. ( #18206 )
...
* Flow additional identities to new principal
* Add extension to more easily get member identity
* Ensure the member is used instead of the backoffice user in `MemberManager`
* Update snippet
* Fix the comment that I broke
* Update src/Umbraco.Web.Common/Extensions/MemberClaimsPrincipalExtensions.cs
Co-authored-by: Andy Butland <abutland73@gmail.com >
---------
Co-authored-by: Andy Butland <abutland73@gmail.com >
2025-02-03 19:48:08 +01:00
Andy Butland
e7411244fd
Show notifications menu only to users with permission for the feature. ( #18184 )
2025-02-03 13:24:58 +01:00
Kenn Jacobsen
9f357173c3
Enforce user start nodes for media uploads through the RTE ( #18204 )
2025-02-03 12:50:23 +01:00
Andy Butland
7dc6e3ed5b
Merge branch 'v13/dev' into v13/contrib
2025-01-31 16:16:22 +01:00
Gareth Wright
5dfff212d0
Update auth.element.ts ( #18192 )
...
auth_username => general_username
2025-01-31 14:59:25 +01:00
TimBoonstra
17615f966b
Fix out of memory of 2gb+ (max 4gb) error introduced by #14657 SVG xss security fix ( #17421 )
...
Co-authored-by: Andy Butland <abutland73@gmail.com >
2025-01-31 13:46:56 +00:00
Kenn Jacobsen
7a2d6b6c63
More robust resolving of Delivery API redirects ( #18160 )
2025-01-31 14:26:07 +01:00
Sven Geusens
343867f6ee
Merge branch 'release/13.6' into v13/dev and version bump
...
# Conflicts:
# src/Umbraco.Web.BackOffice/Controllers/PreviewController.cs
# version.json
2025-01-30 16:27:49 +01:00
Bjarke Berg
b9837ac77c
Optimize Azure pipeline ( #17674 )
...
* Only fetch single commit
* Hopefully fixes Nerdbank.GitVersioning.GitException: Shallow clone lacks the objects required to calculate version height. Use full clones or clones with a history at least as deep as the last version height resetting change.
* Do not checkout again
* More test pipeline
* Another attempt
* yet another attempt
* more attempts
* Revert "more attempts"
This reverts commit 5694d97ba620e90fdeea287936f58002f2a5ddba.
* Test without building backoffice and login explicitly
* Fix mem leak in integration tests
* Fixes sqlserver lock test
# Conflicts:
# build/azure-pipelines.yml
2025-01-30 14:10:05 +01:00
Sven Geusens
bb73ec6c68
Set release version
2025-01-30 09:52:50 +01:00
Andy Butland
ee2d7bbb1b
Excluded tags from trashed content ( #18164 )
2025-01-29 21:10:11 +01:00
Andy Butland
5d48bc7371
Provides an option to remove the inessential version number from the generated models ( #18081 )
...
* Provides an option to remove the inessential version number from the generated models.
* Clarified comment.
2025-01-29 13:33:49 +01:00
Kenn Jacobsen
59a4649528
Do not allow editing read-only properties by clicking their labels ( #18152 )
...
* Do not allow editing read-only properties by clicking their labels
* Simplify the fix :)
* Fix linting issue
2025-01-29 10:29:58 +01:00
Andy Butland
f54b6033ab
Added Resharper test assemblies to exclude list on TypeFinder. ( #18145 )
2025-01-29 10:27:17 +01:00
Jacob Overgaard
bf340cd7d4
fix: remove unused parameters and documentation ( #18095 )
...
this fixes an issue where unused parameters were published as supported, but they were in fact never supported.
2025-01-28 10:53:00 +00:00
Andy Butland
313417cb91
Tidied up XML header comment in ITagQuery.
2025-01-28 10:52:21 +01:00
Kenn Jacobsen
7850078623
Redirect to the published URL when exiting preview ( #18114 )
...
Co-authored-by: Andy Butland <abutland73@gmail.com >
2025-01-24 18:46:28 +00:00
Kenn Jacobsen
44bf3b77b3
Make it possible to reset media picker crops ( #18110 )
...
Co-authored-by: Andy Butland <abutland73@gmail.com >
2025-01-24 13:41:30 +00:00
Kenn Jacobsen
8485458896
Add clientside validation to webhook events ( #18089 )
2025-01-23 17:01:55 +01:00
Nikolaj Geisle
3d253f5f06
bump version
2025-01-23 11:15:26 +01:00
Nikolaj Geisle
64287d7e1a
Merge branch 'release/13.5.3' into release/13.6
...
# Conflicts:
# version.json
2025-01-23 11:14:47 +01:00
Andy Butland
edc78a5a4c
Handles migration case where an expected constraint is renamed but the constraint does not exist. ( #18063 )
2025-01-22 12:26:06 +01:00
Andy Butland
8056a59a10
Fix schema defined in JSON schema tool definition after merge from 13.
2025-01-21 15:52:31 +01:00
Nathaniel Nunes
1a18d6c035
Replaced deprecated navigator.platform with navigator.userAgent for platform detection. ( #17373 )
...
Co-authored-by: Niels Lyngsø <nsl@umbraco.dk >
2025-01-21 13:56:40 +01:00
Andy Butland
3e877182b5
Merge branch 'v13/contrib' into v13/dev
2025-01-21 09:47:20 +01:00
Martin Vennevold
0e4f883bc1
Fix create child issue in list view with infinite editor ( #13355 ). ( #17637 )
2025-01-21 09:44:22 +01:00
Andy Butland
265cc62ab8
Merge branch 'release/13.6' into v13/dev
2025-01-21 09:21:36 +01:00
Andy Butland
800c16970e
Merge branch 'release/13.6' of https://github.com/umbraco/Umbraco-CMS into release/13.6
2025-01-21 09:20:11 +01:00
Andy Butland
6bd11bf233
Fixes failing front-end unit test to align with new behaviour from PR #17818 (
...
Allow skipSelect blueprints only when one blueprint exists).
2025-01-21 09:19:31 +01:00
Kenn Jacobsen
a2fd82a3f3
Add NoopCurrentMemberClaimsProvider so Umbraco can boot without the Delivery API enabled ( #18049 )
2025-01-21 09:13:31 +01:00
Kenn Jacobsen
56c0aebd76
Add NoopCurrentMemberClaimsProvider so Umbraco can boot without the Delivery API enabled ( #18049 )
2025-01-21 09:12:20 +01:00