Commit Graph

34608 Commits

Author SHA1 Message Date
Sebastiaan Janssen
a2c461bcdb Update CONTRIBUTING.md 2021-05-19 13:30:53 +02:00
Sebastiaan Janssen
779c94c66f Update CONTRIBUTING.md 2021-05-19 13:29:02 +02:00
Niels Lyngsø
017b56eee1 #10274 Variant sorting should take into account that there might not be any language (#10278) (#10284)
Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
Co-authored-by: Mads Rasmussen <madsr@hey.com>
2021-05-19 12:06:17 +02:00
Sebastiaan Janssen
14558aea06 Update CONTRIBUTING.md 2021-05-19 10:21:44 +02:00
Sebastiaan Janssen
92cdf4e6e8 Update CONTRIBUTING.md 2021-05-19 10:20:01 +02:00
Sebastiaan Janssen
04326364b2 New issue forms 2021-05-18 15:47:27 +02:00
dependabot[bot]
cce3c49e78 Bump underscore from 1.9.1 to 1.12.1 in /src/Umbraco.Web.UI.Client
Bumps [underscore](https://github.com/jashkenas/underscore) from 1.9.1 to 1.12.1.
- [Release notes](https://github.com/jashkenas/underscore/releases)
- [Commits](https://github.com/jashkenas/underscore/compare/1.9.1...1.12.1)

Signed-off-by: dependabot[bot] <support@github.com>
2021-05-17 10:47:40 +02:00
Paul Seal
aaf5cd5fae Added a link to 404 documentation
I think it will be useful to include a link to the documentation on how to create a custom 404
2021-05-16 07:48:05 +10:00
Chad Currie
474a76fd2b Use ContainsKey for Dictionaries. O(1) 2021-05-15 19:18:37 +10:00
Adam Nelson
980d9ad5cf #10193 The listview search within a dialog (eg. minilistview) shows the loading indicator forever for zero results (#10202)
* The listview search within a dialog (eg. minilistview) shows the loading indicator forever for zero results #10193

* Updated comment.

* Another updated comment.

Co-authored-by: Adam Nelson <anelson@bauerxcelmedia.com.au>
2021-05-12 12:36:13 +10:00
Sebastiaan Janssen
809fd81982 Merge branch 'v8/dev' into v8/contrib
# Conflicts:
#	src/Umbraco.Web.UI.Client/package-lock.json
2021-05-11 10:57:57 +02:00
Patrick de Mooij
499d22aa20 Move the SetWeight logic to WeightedCollectionBuilderBase so other collections can use it too 2021-05-11 14:56:25 +10:00
Bjarne Fyrstenborg
17e43a6b09 Update to noUiSlider v14.6.4 2021-05-11 14:45:00 +10:00
Shannon
f5406b9b2f Updates to Examine 1.2.0
and removes ExecutionContext workaround since it's part of Examine now.
2021-05-11 14:42:29 +10:00
Chad
96d37a5e64 Fix copy button inactive, nodeSelectHandler had too many args passed. (#10158) 2021-05-11 14:32:27 +10:00
dependabot[bot]
8ff88f47de Bump lodash from 4.17.19 to 4.17.21 in /src/Umbraco.Web.UI.Client
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.19 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.19...4.17.21)

Signed-off-by: dependabot[bot] <support@github.com>
2021-05-10 08:58:15 +10:00
patrickdemooij9
ed62f7d672 Add "Insert Macro" as language key (#10164)
* Add "Insert Macro" as language key

* Remove "a" as it wasn't in the original

* Formatting

* add label in FR lanuage  file
2021-05-09 11:42:29 +02:00
Anders Bjerner
68fdc80b6a Added target="_blank" to "Update available" link 2021-05-09 01:29:42 +02:00
Niels Lyngsø
f1e2ef89d1 Merge branch 'v8/bugfix/always-ignorer-validation-when-saving' into v8/dev 2021-05-07 10:59:35 +02:00
Bjarne Fyrstenborg
aaa13303b2 Adjust grid editor layout configuration (#9887)
* Fix wrong end closing tag

* Add button type attribute

* Assign null instead of undefined

* Left align text in row button

* Assign temporary rows to currentLayout

* Cleanup output

* Register functions in vm

* Move nameChanged property to init function

* Don't set toggled as checked when switching columns in row

* Use existing behaviour to set allowAll

* Remove vm.layout again

* copy rows when adding new section + clean up rows on submit and close

Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
Co-authored-by: Mads Rasmussen <madsr@hey.com>
2021-05-07 10:23:19 +02:00
Bjarne Fyrstenborg
a464fadf2c Update spectrum color picker to latest v2.0.8 (#10225)
* Update spectrum color picker to latest v2.0.8

* Update package-lock.json
2021-05-06 12:54:07 +02:00
Niels Lyngsø
6e16550b84 Dont let validation issues prevent saving (#9691)
* skipValidation for content save

* Correcting merge

* Use warning style when saving

* final corrections

* skip client side validation

* remove log

* show invariant property validation issues in the save dialog

* use warning color for .show-validation-type-warning

Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
Co-authored-by: Mads Rasmussen <madsr@hey.com>
2021-05-05 11:18:46 +02:00
Niels Lyngsø
c1dd004604 use warning color for .show-validation-type-warning 2021-05-05 11:15:23 +02:00
Niels Lyngsø
f8c38942f4 Merge remote-tracking branch 'origin/v8/dev' into v8/bugfix/always-ignorer-validation-when-saving
# Conflicts:
#	src/Umbraco.Web.UI.Client/src/common/directives/validation/valformmanager.directive.js
2021-05-05 10:37:27 +02:00
Harikrishna Parmar
857997b5d4 Bugfix/umbraco backoffice icon #10192 (#10212)
* Umbraco backoffice icon #10192

Added umbraco icon

* Update icon-umbraco.svg

updated viewbox
2021-05-05 02:10:26 +02:00
Niels Lyngsø
7ab09cb404 Ensure BlockObjects have references to a working current property editor. (#10195)
Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
2021-05-04 16:58:31 +02:00
Jan Skovgaard
a721f92aed Accessibility: Add focus lock for the infinite editor (#8522)
* Toggle the inert attribute when adding or removing the first/last editor

* Add focus lock directive for the editor

* Increase timeout period so infinite editors transclusions will also have time to finish

* Make sure elements containing .ng-hide are not part of the possible focusable elements

* Update comments

* Conditionally add umb-focus-lock and inert attributes

* Hook into the evenservice to reinitialize the onInit method if the last editor has not been closed when the lock is used in infinite mode

* Don't try to add focus to something that does not exist

* Minor code refactor placing some variables outside the init method

* Refactoring code to make things a bit more clean

* Remove the event listener when the directive is destroyed

* Add mutationObserver to watch for attribute changes and then trigger the getFocusableElements method

* Fetch focusable elements on domChange

* Ensure that args exists before trying to read the properties

* Refactor to use mutationobserver when overlays are closed passing the correct target and re-initialising the directive to activate the focus lock

* Change ng-hide to ng-if so the focusable elements inside the hidden div are not being selected

* Narrow attributes to look for down to the bare minimum of the umb-focus-lock

* Refactor to using good ol' for loop (Fastest)

* Disconnect the observer once the init function has been called - Massive performance improvement

* Event handler cleanup

* Refactor the code to re-initialize the init method on destroy in case infinite editors still exists in the DOM

* Align codestyle

* Add logic to deal with "lastKnowFocused" elements in infinite editing mode

* Re-add attributes after merge with contrib branch

* Correct spelling mistake

* Move onInit into the $includeContentLoaded event and set the timeout to 0

* Make sure to add focus to elements with role="button" as well

* Add comments and remove timeout / delay settings

* Debouce domObserver

* Wrap init function in safeApply

* Add comments to help remember / understand what things are intended to be doing and add missing event param as well as getting rid of some unused code

* Adding more comments

* Move setting of first and last focusable elements into the setElement function

* Remove todo

* Move the setup of first and last focusable elements back to where they were...

Co-authored-by: Joe Glombek <gh@joe.gl>
2021-05-04 10:08:02 +01:00
Niels Lyngsø
c8a98a670c Review AB11194 — Improve media selector UX (#10157)
* set input file accept

* Use PreValue file extensions for limiting the files to be chosen in file input

* Current state for Warren to review

* This should fix up what you need Niels

* update csproj

* use empty string if fileExtensions is undefined

* public interface

* initial work

* local crops

* translations

* translation correction

* fix misspeling

* some progress

* filter media picker

* align media card grid items correctly

* responsive media cropper

* always be able to scale 3 times smallest scale

* making image cropper property editor responsive

* scroll to scale

* adjust slider look

* rearrange parts of mediaentryeditor

* test helper

* styling

* move controls inside umb-image-crop

* seperate umg-cropper-gravity styling

* corrected layout

* more ui refinement

* keep the idea of mandatory out for now.

* remove double ;

* removed testing code

* JSON Property Value Convertor now has an array of property editors to exclude

* Property Value Convertor for Media Picker 3 aka Media Picker with Local Crops

* Experimenting on best approach to retrieve local crop in razor view when iterating over picked media items

* Update ValueConvertor to use ImageCropperValue as part of the model for views as alot of existing CropUrls can then use it

* Update extension methods to take an ImageCropperValue model (localCropData)

* Forgot to update CSProj for new ValueConvertor

* New GetCropUrl @Url.GetCropUrl(crop.Alias, media.LocalCrops) as oppposed to @Url.GetCropUrl(media.LocalCrops, cropAlias:crop.Alias, useCropDimensions: true)

* Remove dupe item in CSProj

* Use a contains as an opposed to Array.IndexOf

* various corrections, SingleMode based on max 1, remove double checkerBackground, enforce validation for Crops, changed error indication

* mediapicker v3

* correct version

* fixing file ext label text color

* clipboard features for MediaPicker v3

* highlight not allowed types

* highlight trashed as an error

* Media Types Video, Sound, Document and Vector Image

* Rename to Audio and VectorGraphics

* Add (SVG) in the name for Vector Graphics

* adding CSV to Documents

* remove this commented code.

* remove this commented code

* number range should not go below 0, at-least as default until we make that configurable.

* use min not ng-min

* description for local crops

* Error/Limits highlighting reactive

* visual adjustments

* Enabling opening filtered folders + corrected select hover states

* Varous fixes to resolve issues with unit tests.

* Refactor MediaType Documents to only contain Article file type

* mark as build-in

* predefined MediaPicker3 DataTypes, renaming v2 to "old"

* set scale bar current value after min and max has been set

* added missing }

* update when focal point is dragged

* adjusted styling for Image Cropper property editor

* correcting comment

* remove todo - message for trashed media items works

* Changed parameter ordering

* Introduced new extension method on MediaWithCrops to get croppings urls in with full path

* Reintroducing Single Item Mode

* use Multiple instead of SingleMode

* renaming and adding multiple to preconfigured datatypes

* Change existing media picker to use the Clipboard type MEDIA, enabling shared functionality.

* clean up unused clipboard parts

* adjusted to new amount

* correcting test

* Fix unit test

* Move MediaWithCrops to separate file and move to Core.Models

* parseContentForPaste

* clean up

* ensure crops is an array.

* actively enable focal points, so we dont set focal points that aren't used.

* only accept files that matches file extensions from Umbraco Settings

* Cleanup

* Add references from MediaPicker3 to media

* corrections from various feedback

* remove comment

* correct wording

* use windowResizeListener

* Show Media Type Selector if there is multiple types that matches the current upload batch

* clean-up and refactoring

* auto pick option

Co-authored-by: Warren Buckley <warren@umbraco.com>
Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
Co-authored-by: Mads Rasmussen <madsr@hey.com>
Co-authored-by: Andy Butland <abutland73@gmail.com>
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
Co-authored-by: Sebastiaan Janssen <sebastiaan@umbraco.com>
Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>
2021-05-04 11:06:52 +02:00
Niels Lyngsø
c2fd28810b show invariant property validation issues in the save dialog 2021-05-04 10:38:26 +02:00
Niels Lyngsø
ce34165e9d use formCtrl.$invalid instead of running angularHelper.countAllFormErrors, as this method is way too heavy to run in a $watch. (#10134)
Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
2021-05-03 16:18:15 +02:00
Niels Lyngsø
0b4be695cf Merge remote-tracking branch 'origin/v8/dev' into v8/bugfix/always-ignorer-validation-when-saving 2021-05-03 15:47:36 +02:00
Niels Lyngsø
dcfdcb11de remove log 2021-05-03 11:29:52 +02:00
Mole
d8d4be9e8e Backport cache key fix and optimizations (#10199)
* Add GetKey<T, TId>

* Update Usages of GetKey and remove GetKey<T>(object)

We shouldn't have to retain this since RepositoryCacheKeys is internal.

* Apply changes to DefaultRepositoryCachePolicy

* Add check for default/less than -1 on UserRepository PerformGet

Co-authored-by: Nikolaj <nel@umbraco.dk>
2021-05-03 10:22:42 +02:00
Bjarne Fyrstenborg
727be420ff Use umb-icon component in listview dropdown 2021-04-29 08:40:00 +10:00
Bjarne Fyrstenborg
349c5ac3ab Fix issue with active style affected nested block list elements 2021-04-29 08:21:36 +10:00
Mike Chambers
b783399c5c Update ModelsBuilderComposer.cs
issue #10186

typo in IsExternalModelsBuilderInstalled -> Umbraco.ModelsBuider
2021-04-28 18:05:40 +02:00
Sebastiaan Janssen
e7a3fd37ce Revert "Fixed copy preserving sort order (#10091)"
This reverts commit 26d11a8314.
2021-04-27 14:57:17 +02:00
Anders Bjerner
4ade2264d2 Minor Danish translations 2021-04-27 08:06:57 +10:00
Shannon
22afe5e341 Adds cold boot restart to load test proj 2021-04-26 15:40:46 +10:00
Mads Rasmussen
4369747c72 skip client side validation 2021-04-22 16:55:18 +02:00
Sebastiaan Janssen
c885831e02 Revert "use v8 branch as default for API Docs"
This reverts commit 0dfefb72cb.
2021-04-22 16:34:11 +02:00
Arkadiusz Biel
0dfefb72cb use v8 branch as default for API Docs 2021-04-22 16:12:20 +02:00
Niels Lyngsø
1a5b88525b Media Picker v3 (#9461)
* set input file accept

* Use PreValue file extensions for limiting the files to be chosen in file input

* Current state for Warren to review

* This should fix up what you need Niels

* update csproj

* use empty string if fileExtensions is undefined

* public interface

* initial work

* local crops

* translations

* translation correction

* fix misspeling

* some progress

* filter media picker

* align media card grid items correctly

* responsive media cropper

* always be able to scale 3 times smallest scale

* making image cropper property editor responsive

* scroll to scale

* adjust slider look

* rearrange parts of mediaentryeditor

* test helper

* styling

* move controls inside umb-image-crop

* seperate umg-cropper-gravity styling

* corrected layout

* more ui refinement

* keep the idea of mandatory out for now.

* remove double ;

* removed testing code

* JSON Property Value Convertor now has an array of property editors to exclude

* Property Value Convertor for Media Picker 3 aka Media Picker with Local Crops

* Experimenting on best approach to retrieve local crop in razor view when iterating over picked media items

* Update ValueConvertor to use ImageCropperValue as part of the model for views as alot of existing CropUrls can then use it

* Update extension methods to take an ImageCropperValue model (localCropData)

* Forgot to update CSProj for new ValueConvertor

* New GetCropUrl @Url.GetCropUrl(crop.Alias, media.LocalCrops) as oppposed to @Url.GetCropUrl(media.LocalCrops, cropAlias:crop.Alias, useCropDimensions: true)

* Remove dupe item in CSProj

* Use a contains as an opposed to Array.IndexOf

* various corrections, SingleMode based on max 1, remove double checkerBackground, enforce validation for Crops, changed error indication

* mediapicker v3

* correct version

* fixing file ext label text color

* clipboard features for MediaPicker v3

* highlight not allowed types

* highlight trashed as an error

* Media Types Video, Sound, Document and Vector Image

* Rename to Audio and VectorGraphics

* Add (SVG) in the name for Vector Graphics

* adding CSV to Documents

* remove this commented code.

* remove this commented code

* number range should not go below 0, at-least as default until we make that configurable.

* use min not ng-min

* description for local crops

* Error/Limits highlighting reactive

* visual adjustments

* Enabling opening filtered folders + corrected select hover states

* Varous fixes to resolve issues with unit tests.

* Refactor MediaType Documents to only contain Article file type

* mark as build-in

* predefined MediaPicker3 DataTypes, renaming v2 to "old"

* set scale bar current value after min and max has been set

* added missing }

* update when focal point is dragged

* adjusted styling for Image Cropper property editor

* correcting comment

* remove todo - message for trashed media items works

* Changed parameter ordering

* Introduced new extension method on MediaWithCrops to get croppings urls in with full path

* Reintroducing Single Item Mode

* use Multiple instead of SingleMode

* renaming and adding multiple to preconfigured datatypes

* Change existing media picker to use the Clipboard type MEDIA, enabling shared functionality.

* clean up unused clipboard parts

* adjusted to new amount

* correcting test

* Fix unit test

* Move MediaWithCrops to separate file and move to Core.Models

* parseContentForPaste

* clean up

* ensure crops is an array.

* actively enable focal points, so we dont set focal points that aren't used.

* only accept files that matches file extensions from Umbraco Settings

* Cleanup

* Add references from MediaPicker3 to media

* corrections from various feedback

* remove comment

* correct wording

* use windowResizeListener

Co-authored-by: Warren Buckley <warren@umbraco.com>
Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
Co-authored-by: Mads Rasmussen <madsr@hey.com>
Co-authored-by: Andy Butland <abutland73@gmail.com>
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
Co-authored-by: Sebastiaan Janssen <sebastiaan@umbraco.com>
Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>
2021-04-22 10:28:53 +02:00
Niels Lyngsø
021c0b82c1 final corrections 2021-04-20 11:35:40 +02:00
Niels Lyngsø
eeb30db36d Merge remote-tracking branch 'origin/v8/bugfix/use-warning-message-style-when-saving' into v8/bugfix/always-ignorer-validation-when-saving
# Conflicts:
#	src/Umbraco.Web.UI.Client/src/common/directives/components/content/edit.controller.js
2021-04-20 11:16:20 +02:00
Niels Lyngsø
12cde0c571 Use warning style when saving 2021-04-20 11:10:07 +02:00
Mole
0c3788eba1 Merge pull request #10061 from umbraco/v8/feature/AB10632-recycle-bin-smells-caching
RecycleBinSmells caching
2021-04-16 13:14:33 +02:00
Elitsa Marinovska
7d09de6d0f Removing unused param 2021-04-15 10:33:21 +02:00
Elitsa Marinovska
8e14543616 Merge remote-tracking branch 'origin/v8/dev' into v8/feature/AB10632-recycle-bin-smells-caching 2021-04-15 09:02:53 +02:00
Elitsa Marinovska
038afa5664 Fixing tests after adding the new event related to EmptiedRecycleBin 2021-04-15 09:00:58 +02:00