Amended signatures of method under test to support testing without the previously observed behaviour of an erroring test passing but crashing the test runner process.
* Implemented health check notifier as a hosted service.
Added validation to health check settings.
* Registered health check notifier as a hosted service.
Modified health check nested settings to use concrete classes to align with other configuration models.
* Resolved issues with email sending using development server.
* PR review comments and fixed failing unit test.
* Changed period and delay millisecond and hourly values to TimeSpans.
Changed configuration of first run time for health check notifications to use H:mm format.
* Set up SecureSocketOptions as a locally defined enum.
* Tightened up time format validation to verify input is an actual time (with hours and minutes only) and not a timespan.
* Aligned naming and namespace of health check configuration related classes with other configuration classes.
* Created constants for hex colors used in formatting health check results as HTML.
* Revert "Tightened up time format validation to verify input is an actual time (with hours and minutes only) and not a timespan."
This reverts commit f9bb8a7a825bcb58146879f18b47922e09453e2d.
* Renamed method to be clear validation is of a TimeSpan and not a time.
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
* Replace IFactory with IServiceProvider
* Replace IRegister with IServiceCollection
* Fix Rte.cshtml so the view can service locate.
* Replace Composing Lifetime with MSDI ServiceLifetime
* Remove ServiceProvider AddMultipleUnique extension
* Remove Umbraco.Web.Composing.Current.Reset and any calls
* Remove LightInject from net framework projects
* Brought back a helper for setting MediaFileSystem underlying IFileSystem
* Moved adapters from Infra -> Core
* Allow Composition to accept a service collection instead of an IRegister
* Composition no longer takes IRegister as constructor arg
all tests passing
* Composition no longer implements IRegister
* Lose _uniques in Composition
* lose Composition OnCreatingFactory actions
* Clean up UmbracoCoreServiceCollectionExtensions & Composition
Less IFactory
* LightInject gone where TFW == netstandard2.0 || TFW == netcoreapp3.1
* Resolve dead code issues
* Rename IFactory methods to match IServiceProvider so they can be trivially swapped later.
* Rename IFactory methods to match IServiceProvider so they can be trivially swapped later (continued)
Thought the counts were low, it's mostly extension method usage
* Align namespaces in integration tests
* Align namespaces in unit tests
* Align namespaces in Backoffice.Filters
* Align namespaces in Backoffice.ActionResults
* Align namespaces in Backoffice.Mapping
* Align namespaces in Backoffice.PorpertyEditors and SignalR
* Align namespaces in Backoffice.Trees
* Align unit tests after migration
* Doesn't make much sense to have Concrete on IRegister, only on IFactory
* Handle FilesTreeController requires IFileSystem of type PhysicalFileSystem
* Handle registration of default MediaFileSystem without using RegisterUniqueFor
* Remove RegisterFor / RegisterUniqueFor from IRegister
* Switch over from LightInject to wrappers around MSDI
* Made mapper dependencies more explicit
* Remove registration for AngularJsonMediaTypeFormatter
It's dependencies aren't registered so container validation fails
* Resolve lifetime issue for EnsureValidSessionId by service locating
else resolve scoped in singleton
* Make registration more explicit for backoffice UserManager
* Make install step registrations more explicit
* Disable service provider validation so site can launch
Maybe this is a problem maybe not, we build about 8000 service providers so maybe everything is fine later...
* Further cleanup of IFactory interface
* Further cleanup of IRegister interface
* Revert "Make registration more explicit for backoffice UserManager"
This reverts commit 7215fe836103c597cd0873c66737a79b91ed4c49.
* Resolve issue where NewInstallStep would fail to reset password for "SuperUser"
Before MSDI, somehow BackOfficeIdentityOptions would be configured with token provider map from IdentityBuilder.AddDefaultTokenProviders.
After switchover those config actions are lost.
Subclass IdentityBuilder to ensure BackOfficeIdentityOptions doesn't miss config setup upstream.
* Initialize current.
* Add todo to turn container validation back on.
* Migrated ScopeFileSystemsTests to integration tests
Signed-off-by: Bjarke Berg <mail@bergmania.dk>
* Resolve issue where MediaFileSystem was skipping ShadowFileSystem
* Attempt to fix ScopeFileSystemsTests on azure devops
Signed-off-by: Bjarke Berg <mail@bergmania.dk>
* Be interesting to know what the actual full path is in pipeline.
* Clarify intent of CreateMediaTest
Doesn't help resolve weird UnauthorizedAccessException but it cuts so much cognitive overhead for the future.
* Use ILoggerfactory rather than mock for the manually constructed file PhysicalFileSystem
* Maybe resolve failing test on azure pipeline.
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
