Commit Graph

34556 Commits

Author SHA1 Message Date
Niels Lyngsø
c8a98a670c Review AB11194 — Improve media selector UX (#10157)
* set input file accept

* Use PreValue file extensions for limiting the files to be chosen in file input

* Current state for Warren to review

* This should fix up what you need Niels

* update csproj

* use empty string if fileExtensions is undefined

* public interface

* initial work

* local crops

* translations

* translation correction

* fix misspeling

* some progress

* filter media picker

* align media card grid items correctly

* responsive media cropper

* always be able to scale 3 times smallest scale

* making image cropper property editor responsive

* scroll to scale

* adjust slider look

* rearrange parts of mediaentryeditor

* test helper

* styling

* move controls inside umb-image-crop

* seperate umg-cropper-gravity styling

* corrected layout

* more ui refinement

* keep the idea of mandatory out for now.

* remove double ;

* removed testing code

* JSON Property Value Convertor now has an array of property editors to exclude

* Property Value Convertor for Media Picker 3 aka Media Picker with Local Crops

* Experimenting on best approach to retrieve local crop in razor view when iterating over picked media items

* Update ValueConvertor to use ImageCropperValue as part of the model for views as alot of existing CropUrls can then use it

* Update extension methods to take an ImageCropperValue model (localCropData)

* Forgot to update CSProj for new ValueConvertor

* New GetCropUrl @Url.GetCropUrl(crop.Alias, media.LocalCrops) as oppposed to @Url.GetCropUrl(media.LocalCrops, cropAlias:crop.Alias, useCropDimensions: true)

* Remove dupe item in CSProj

* Use a contains as an opposed to Array.IndexOf

* various corrections, SingleMode based on max 1, remove double checkerBackground, enforce validation for Crops, changed error indication

* mediapicker v3

* correct version

* fixing file ext label text color

* clipboard features for MediaPicker v3

* highlight not allowed types

* highlight trashed as an error

* Media Types Video, Sound, Document and Vector Image

* Rename to Audio and VectorGraphics

* Add (SVG) in the name for Vector Graphics

* adding CSV to Documents

* remove this commented code.

* remove this commented code

* number range should not go below 0, at-least as default until we make that configurable.

* use min not ng-min

* description for local crops

* Error/Limits highlighting reactive

* visual adjustments

* Enabling opening filtered folders + corrected select hover states

* Varous fixes to resolve issues with unit tests.

* Refactor MediaType Documents to only contain Article file type

* mark as build-in

* predefined MediaPicker3 DataTypes, renaming v2 to "old"

* set scale bar current value after min and max has been set

* added missing }

* update when focal point is dragged

* adjusted styling for Image Cropper property editor

* correcting comment

* remove todo - message for trashed media items works

* Changed parameter ordering

* Introduced new extension method on MediaWithCrops to get croppings urls in with full path

* Reintroducing Single Item Mode

* use Multiple instead of SingleMode

* renaming and adding multiple to preconfigured datatypes

* Change existing media picker to use the Clipboard type MEDIA, enabling shared functionality.

* clean up unused clipboard parts

* adjusted to new amount

* correcting test

* Fix unit test

* Move MediaWithCrops to separate file and move to Core.Models

* parseContentForPaste

* clean up

* ensure crops is an array.

* actively enable focal points, so we dont set focal points that aren't used.

* only accept files that matches file extensions from Umbraco Settings

* Cleanup

* Add references from MediaPicker3 to media

* corrections from various feedback

* remove comment

* correct wording

* use windowResizeListener

* Show Media Type Selector if there is multiple types that matches the current upload batch

* clean-up and refactoring

* auto pick option

Co-authored-by: Warren Buckley <warren@umbraco.com>
Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
Co-authored-by: Mads Rasmussen <madsr@hey.com>
Co-authored-by: Andy Butland <abutland73@gmail.com>
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
Co-authored-by: Sebastiaan Janssen <sebastiaan@umbraco.com>
Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>
2021-05-04 11:06:52 +02:00
Niels Lyngsø
ce34165e9d use formCtrl.$invalid instead of running angularHelper.countAllFormErrors, as this method is way too heavy to run in a $watch. (#10134)
Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
2021-05-03 16:18:15 +02:00
Mole
d8d4be9e8e Backport cache key fix and optimizations (#10199)
* Add GetKey<T, TId>

* Update Usages of GetKey and remove GetKey<T>(object)

We shouldn't have to retain this since RepositoryCacheKeys is internal.

* Apply changes to DefaultRepositoryCachePolicy

* Add check for default/less than -1 on UserRepository PerformGet

Co-authored-by: Nikolaj <nel@umbraco.dk>
2021-05-03 10:22:42 +02:00
Niels Lyngsø
1a5b88525b Media Picker v3 (#9461)
* set input file accept

* Use PreValue file extensions for limiting the files to be chosen in file input

* Current state for Warren to review

* This should fix up what you need Niels

* update csproj

* use empty string if fileExtensions is undefined

* public interface

* initial work

* local crops

* translations

* translation correction

* fix misspeling

* some progress

* filter media picker

* align media card grid items correctly

* responsive media cropper

* always be able to scale 3 times smallest scale

* making image cropper property editor responsive

* scroll to scale

* adjust slider look

* rearrange parts of mediaentryeditor

* test helper

* styling

* move controls inside umb-image-crop

* seperate umg-cropper-gravity styling

* corrected layout

* more ui refinement

* keep the idea of mandatory out for now.

* remove double ;

* removed testing code

* JSON Property Value Convertor now has an array of property editors to exclude

* Property Value Convertor for Media Picker 3 aka Media Picker with Local Crops

* Experimenting on best approach to retrieve local crop in razor view when iterating over picked media items

* Update ValueConvertor to use ImageCropperValue as part of the model for views as alot of existing CropUrls can then use it

* Update extension methods to take an ImageCropperValue model (localCropData)

* Forgot to update CSProj for new ValueConvertor

* New GetCropUrl @Url.GetCropUrl(crop.Alias, media.LocalCrops) as oppposed to @Url.GetCropUrl(media.LocalCrops, cropAlias:crop.Alias, useCropDimensions: true)

* Remove dupe item in CSProj

* Use a contains as an opposed to Array.IndexOf

* various corrections, SingleMode based on max 1, remove double checkerBackground, enforce validation for Crops, changed error indication

* mediapicker v3

* correct version

* fixing file ext label text color

* clipboard features for MediaPicker v3

* highlight not allowed types

* highlight trashed as an error

* Media Types Video, Sound, Document and Vector Image

* Rename to Audio and VectorGraphics

* Add (SVG) in the name for Vector Graphics

* adding CSV to Documents

* remove this commented code.

* remove this commented code

* number range should not go below 0, at-least as default until we make that configurable.

* use min not ng-min

* description for local crops

* Error/Limits highlighting reactive

* visual adjustments

* Enabling opening filtered folders + corrected select hover states

* Varous fixes to resolve issues with unit tests.

* Refactor MediaType Documents to only contain Article file type

* mark as build-in

* predefined MediaPicker3 DataTypes, renaming v2 to "old"

* set scale bar current value after min and max has been set

* added missing }

* update when focal point is dragged

* adjusted styling for Image Cropper property editor

* correcting comment

* remove todo - message for trashed media items works

* Changed parameter ordering

* Introduced new extension method on MediaWithCrops to get croppings urls in with full path

* Reintroducing Single Item Mode

* use Multiple instead of SingleMode

* renaming and adding multiple to preconfigured datatypes

* Change existing media picker to use the Clipboard type MEDIA, enabling shared functionality.

* clean up unused clipboard parts

* adjusted to new amount

* correcting test

* Fix unit test

* Move MediaWithCrops to separate file and move to Core.Models

* parseContentForPaste

* clean up

* ensure crops is an array.

* actively enable focal points, so we dont set focal points that aren't used.

* only accept files that matches file extensions from Umbraco Settings

* Cleanup

* Add references from MediaPicker3 to media

* corrections from various feedback

* remove comment

* correct wording

* use windowResizeListener

Co-authored-by: Warren Buckley <warren@umbraco.com>
Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
Co-authored-by: Mads Rasmussen <madsr@hey.com>
Co-authored-by: Andy Butland <abutland73@gmail.com>
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
Co-authored-by: Sebastiaan Janssen <sebastiaan@umbraco.com>
Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>
2021-04-22 10:28:53 +02:00
Mole
0c3788eba1 Merge pull request #10061 from umbraco/v8/feature/AB10632-recycle-bin-smells-caching
RecycleBinSmells caching
2021-04-16 13:14:33 +02:00
Elitsa Marinovska
7d09de6d0f Removing unused param 2021-04-15 10:33:21 +02:00
Elitsa Marinovska
8e14543616 Merge remote-tracking branch 'origin/v8/dev' into v8/feature/AB10632-recycle-bin-smells-caching 2021-04-15 09:02:53 +02:00
Elitsa Marinovska
038afa5664 Fixing tests after adding the new event related to EmptiedRecycleBin 2021-04-15 09:00:58 +02:00
Elitsa Marinovska
2534f99cdb Adding new RecycleBin event handlers 2021-04-14 16:55:37 +02:00
Shannon Deminick
de4a7eff85 Fixes some property editors ensuring ngModelController(#10013)
Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
2021-04-12 15:19:32 +02:00
Niels Lyngsø
18fa631f1c use paste-resolvers (#10121)
Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
2021-04-12 14:38:52 +02:00
Niels Lyngsø
8d8fb2d15c Dont show block catalogue if only one block is available. Enable ente… (#9575)
* Dont show block catalogue if only one block is available. Enable entering clipboard directly.

* corrected button states

* jump clipboard icon when adding items to the clipboard.

* fix merge issue

* add missing eventsService

* correcting missing parts from Merge

Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
Co-authored-by: Mads Rasmussen <madsr@hey.com>
2021-04-12 12:27:12 +02:00
Sebastiaan Janssen
8c20e252dc Merge branch 'v8/8.13' into v8/dev 2021-04-07 16:26:48 +02:00
Sebastiaan Janssen
ecf67669ce Attributes could be multiple items, test specifically if Directory is an attribute 2021-04-07 16:25:46 +02:00
Sebastiaan Janssen
9fdbbb54fb Update cypress test to make macros in the grid work again 2021-04-07 15:44:28 +02:00
Mole
f6eb8c9dbb Merge pull request #9995 from umbraco/v8/feature/10615-mappers-with-explicit-scope
Create explicit scope for mappers in UmbracoMapper
2021-04-07 14:58:39 +02:00
Mole
8b6fc762b5 Reintroduce old constructor to make non-breaking 2021-04-07 13:54:42 +02:00
Sebastiaan Janssen
2d2a89f216 Revert "Add copy logic to Media Picker (#9957)"
This reverts commit f7c032af65.
2021-04-07 13:42:46 +02:00
Sebastiaan Janssen
d85d0d75f3 Revert "Updated LightInject to v6.4.0"
This reverts commit fc77252ec7.
2021-04-06 16:13:40 +02:00
Sebastiaan Janssen
89b881e98e Bump version to 8.13 RC 2021-04-06 10:11:46 +02:00
Sebastiaan Janssen
3358ab2604 Also make sure NuGet installs the correct version of the CodePages dependency 2021-04-06 10:08:10 +02:00
Sebastiaan Janssen
c84f616a17 Remove HtmlSanitizer once more - see #9803 2021-04-06 10:08:10 +02:00
Dave de Moel
fc77252ec7 Updated LightInject to v6.4.0 2021-04-06 09:35:12 +02:00
Rachel Breeze
db6d572235 Accessibility: Alerts the user how many results have been returned on a tree search (#10100)
* Added support for screeen reader alerts on the embed so that assitive technology knows when a url retrieve has been succesfull.
Added labels for the controls
Preview reload only triggered if the values for height and width change

* Tree search details the number of search items returned

* Add French translations
2021-04-06 03:50:14 +02:00
Rachel Breeze
739d9a8188 Improved accessibility of link picker (#10099)
* Added support for screeen reader alerts on the embed so that assitive technology knows when a url retrieve has been succesfull.
Added labels for the controls
Preview reload only triggered if the values for height and width change

* Added control ids for the link picker

* Add French translation
2021-04-06 03:44:14 +02:00
Mads Rasmussen
f549a36593 fixes #10021 adds ng-form and val-form-manager to the documentation 2021-04-06 07:42:05 +10:00
patrickdemooij9
f8e280e0b4 9962: Use $allowedEditors instead of allowed (#10086)
* 9962: Use $allowedEditors instead of allowed

* 9962: Remove redundant statement
2021-04-04 02:16:02 +02:00
Bjarne Fyrstenborg
f83f465211 Fix validation of step size in integer/numeric field 2021-04-03 02:59:24 +02:00
Sebastiaan Janssen
d428a4543f Merge branch 'v8/dev' into v8/contrib 2021-03-31 17:27:13 +02:00
Sebastiaan Janssen
d7519e29d0 Merge branch 'v8/8.12' into v8/dev 2021-03-31 17:26:25 +02:00
Bjarne Fyrstenborg
72e468428a Null check on scope and options to ensure backward compatibility
(cherry picked from commit fe8cd239d2)
2021-03-31 14:42:05 +02:00
Sebastiaan Janssen
e8a9c4da2e Merge branch 'v8/dev' into v8/contrib 2021-03-31 13:01:25 +02:00
Sebastiaan Janssen
2f60a471b3 Merge branch 'v8/8.12' into v8/dev 2021-03-31 13:00:32 +02:00
Sebastiaan Janssen
acaf1941fe Merge branch 'v8/8.11' into v8/8.12 2021-03-31 12:59:56 +02:00
Mads Rasmussen
15923aafc7 Fixes tabbing-mode remains active after closing modal #9790 (#10074)
(cherry picked from commit c881fa9e7d)
2021-03-31 12:55:48 +02:00
Bjarne Fyrstenborg
d08b84d28f Allow to pass in boolean to preventEnterSubmit directive (#8639)
* Pass in value to preventEnterSubmit directive

* Set enabled similar to preventDefault and preventEnterSubmit directives

* Update prevent enter submit value

* Init value from controller

* Use a different default input id prefix for umb-search-filter

* Fix typo

* Check for truthly value

* Revert "Set enabled similar to preventDefault and preventEnterSubmit directives"

This reverts commit 536ce855c4545ead82cea77b4013bf9010a8687b.

* None pointer events when clicking icon

* Use color variable
2021-03-31 10:01:33 +01:00
Mads Rasmussen
c881fa9e7d Fixes tabbing-mode remains active after closing modal #9790 (#10074) 2021-03-30 17:03:56 +02:00
BeardinaSuit
e7ce6a307e Handle Invalid format for Upgrade check 2021-03-30 15:08:00 +02:00
Nathan Woulfe
958e25d4ba Revert updating deprecated WriterName/CreatorName refs
Changing the properties to use the extensions is a good thing (given the props are deprecated), but causes issues deep in tests. I'm reverting that change to fix the tests, and all refs to the deprecated properties should be updated in one sweep, to deal with any other test issues that might crop up.
2021-03-30 13:22:04 +02:00
Andy Butland
6299ea0862 Orders member type grouping of members alphabetically, matching the listing of member types. 2021-03-30 17:31:46 +10:00
Ronald Barendse
dcc07fd612 Add Root<T> and Breadcrumbs extension methods for IPublishedContent (#9033)
* Fix usage of obsolete CreatorName and WriterName properties

* Add generic Root extension method

* Add Breadcrumbs extension methods
2021-03-29 09:13:53 +10:00
Callum Whyte
121ae2e8a9 Handling multiple values per field in Examine Management 2021-03-29 08:34:55 +10:00
Elitsa Marinovska
05e9710ca6 Using an atomic operation when calling GetCacheItem - a callback is specified when the item isn't found 2021-03-25 13:29:27 +01:00
Elitsa Marinovska
19c17836aa Adding recycle bin smells caches at repository level 2021-03-25 12:54:46 +01:00
Mole
499e4f0c42 Merge pull request #9999 from umbraco/v8/feature/AB10891-content-dashboard-config
Granting access to the content dashboard for all user groups
2021-03-25 12:03:33 +01:00
Elitsa Marinovska
d2a26bf4da Caching RecycleBinSmells 2021-03-25 11:49:38 +01:00
Elitsa Marinovska
f68d4d6968 Taking AllowContentDashboardAccessToAllUsers prop from GlobalSettings to ContentDashboardSettings and saving AccessRulesFromConfig into a backing field 2021-03-25 11:11:41 +01:00
Elitsa Marinovska
56d5704167 bool.Try 2021-03-24 16:15:21 +01:00
Bjarke Berg
bfc3068d6a Merge pull request #10056 from umbraco/v8/feature/new-cypress-content-tests
Add new cypress tests
2021-03-24 16:03:29 +01:00
Elitsa Marinovska
91ce071271 Merge remote-tracking branch 'origin/v8/dev' into v8/feature/AB10891-content-dashboard-config 2021-03-24 15:43:33 +01:00