Commit Graph

40077 Commits

Author SHA1 Message Date
Ronald Barendse
fed720042c Fix ParseConnectionString to pass tests 2021-09-20 11:38:54 +02:00
Ronald Barendse
bc29155032 Fix parsing of connection string during setup 2021-09-18 00:23:47 +02:00
Ronald Barendse
fd5cef6b42 Support DataDirectory placeholder in LocalDB connection string 2021-09-17 20:20:36 +02:00
Ronald Barendse
4ad34270dd Remove runtime state dependency in InstallHelper 2021-09-17 19:59:54 +02:00
Ronald Barendse
ab28251558 Use RuntimeState to determine whether to install missing database 2021-09-17 16:30:46 +02:00
Ronald Barendse
d702b2f616 Fix non-Windows database configuration install step 2021-09-17 13:10:21 +02:00
Ronald Barendse
51002ba7a4 Minor code cleanup 2021-09-17 12:52:23 +02:00
Ronald Barendse
074bbb045b Install missing database during unattended install 2021-09-17 12:52:05 +02:00
Ronald Barendse
81cbbd8614 Add LocalDB database option to installer 2021-09-17 12:50:25 +02:00
Ronald Barendse
785630922e Rename IEmbeddedDatabaseCreator to IDatabaseCreator and refactor implementations 2021-09-17 12:48:48 +02:00
Ronald Barendse
b82fc3350f Set default UmbracoConnectionString value 2021-09-17 11:57:49 +02:00
Ronald Barendse
57610c96b9 Detect as brand new install if we can't connect and InstallMissingDatabase is enabled 2021-09-17 11:57:20 +02:00
Ronald Barendse
aa15b0d244 Simplify parsing provider name from connection string 2021-09-15 15:41:20 +02:00
Ronald Barendse
27043bec59 Remove custom SQL CE checks from IsConnectionStringConfigured 2021-09-15 15:30:21 +02:00
Nikolaj Geisle
fa0fb5a2a2 Merge pull request #11065 from umbraco/v9/missing-gitignore-in-template
Commit missing update to ensure gitignore file is packed in Umbraco.T…
2021-09-10 11:13:06 +02:00
Bjarke Berg
c8a67528ea Merge pull request #11071 from umbraco/v9/bugfix/empty-recycle-bin-index
Fixes empty recycle bin performance with indexing
2021-09-10 11:10:15 +02:00
Nikolaj Geisle
088d87bac6 Merge pull request #11064 from umbraco/v9/bugfix/10650-fix_issue_with_upgrading_while_in_backoffice
Add redirect to /umbraco if you are not in run state.
2021-09-10 10:50:41 +02:00
Nikolaj Geisle
1291a38097 Merge pull request #11060 from umbraco/v9/bugfix/110056-added_missing_null_check_when_conneciton_is_missing
Fixes issue when ConnectionStrings.umbracoDbDSN is missing
2021-09-10 10:33:07 +02:00
Bjarke Berg
583549c768 Fixed test 2021-09-10 09:25:56 +02:00
Bjarke Berg
0db6d542ea Cleanup 2021-09-10 09:24:11 +02:00
Bjarke Berg
7ffdf72519 Merge pull request #11068 from umbraco/v9/bugfix/options-monitor-connection-strings
Fixes reading connection strings after install
2021-09-10 09:22:39 +02:00
Mole
dd03b25a43 Merge pull request #11054 from umbraco/v9/bugfix/#10403-Fixed-Notification-with-UmbracoAuthorizedController
v9: Bugfix - Implemented attribute changes in controller
2021-09-10 09:18:06 +02:00
Shannon
71448eafe6 Fixes empty recycle bin performance with indexing
Currently when the recycle bin is empty, it is going to individually delete each item from the index. This is going to cause tons of allocations in Umbraco for DeferedDeleteIndex objects for each item and then down within Examine is going to process each one individually instead of just doing it in bulk. There will be a lot of allocations made there too along with a bunch of extra and unecessary threads.
2021-09-09 16:04:18 -06:00
Shannon
769f24aaae Fixes reading connection strings after install
The issue was discovered when testing Umbraco Id. If you have an existing install and there is a pending Umbraco migration (upgrade), but you clear out the connection string to force a new install screen, fill out the existing connection string details, it all works and redirects to the back office. This will throw exceptions because the runtime state is in an upgrade state (which is fixed in #11064) but if you then logout and try to log in with an active OAuth provider, it means there is a redirect outside of Umbraco and back again and you'll end up back on the installer screen - but it will not show you the upgrade screen, instead it shows you the normal install screen. This is because we are not using IOptionsMonitor for connection string settings which means it's already read the original empty connection string setting fom the very beginning and isn't reading the current/updated value.

We need to review all IOptions usages. Most of them should be IOptionsMonitor unless its impossible to change the app behavior at runtime with a particular config option.
2021-09-09 13:15:11 -06:00
Bjarke Berg
41aabd2515 https://github.com/umbraco/Umbraco-CMS/issues/10650 - Added redirect in backoffice controller if you are not in run state. 2021-09-09 15:37:13 +02:00
Warren Buckley
b8316d151e Commit missing update to ensure gitignore file is packed in Umbraco.Templates 2021-09-09 14:36:34 +01:00
Bjarke Berg
d121456054 https://github.com/umbraco/Umbraco-CMS/issues/11056 Handle null checks 2021-09-09 13:08:27 +02:00
Nikolaj Geisle
dc0994a429 Merge pull request #11059 from umbraco/v9/bugfix/application-url-in-appsettings
V9: Fix ApplicationMainUrl not being set from appsettings.json
2021-09-09 12:39:41 +02:00
Mole
985eb1420d Merge pull request #10964 from umbraco/v9/bugfix/imagesize-cleanup
Use ImageSharps Image.Identify for dimension extraction
2021-09-09 12:29:17 +02:00
Nikolaj
acf0052f8e Merge branch 'v9/dev' into v9/bugfix/imagesize-cleanup
# Conflicts:
#	src/Umbraco.Infrastructure/DependencyInjection/UmbracoBuilder.CoreServices.cs
2021-09-09 11:40:17 +02:00
Nikolaj
7578d460c4 Assign ApplicationMainUrl in constructor of hosting environment if its specified in appsettings 2021-09-09 11:18:12 +02:00
Bjarke Berg
36582f2cd2 Merge pull request #11045 from umbraco/v9/gitignore-in-template
Ship a gitignore in Umbraco V9 dotnet new template
2021-09-08 21:19:35 +02:00
Warren Buckley
d797351349 Update build/templates/UmbracoProject/.gitignore
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
2021-09-08 20:16:07 +01:00
Bjarke Berg
97486e0705 Merge pull request #11050 from umbraco/v9/bugfix/fix-imagecropper-trygetmediapath
Fix Image Cropper media path parsing
2021-09-08 21:03:46 +02:00
Warren Buckley
c6c924179b Update build/templates/UmbracoProject/.gitignore
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
2021-09-08 19:55:56 +01:00
Bjarke Berg
2cfb099dea Merge pull request #11058 from umbraco/v9/bugfix/fix-email-handler-detection
Fixes email handler detection
2021-09-08 19:59:23 +02:00
Shannon
8ff78fb1de Fixes email handler detection 2021-09-08 11:19:52 -06:00
Bjarke Berg
1d55d50809 Merge pull request #11046 from umbraco/v9/feature/merge_v8.17-rc
Merge 8.17 RC into V9, cleanup/refactor property groups/tabs API
2021-09-08 19:17:02 +02:00
Bjarke Berg
42e27450d9 Merge pull request #11053 from umbraco/v9/bugfix/add_missing_action
V9: Fixed missing action
2021-09-08 19:16:47 +02:00
Bjarke Berg
3eb21d5bbd Merge pull request #11016 from umbraco/v9/feature/add_friendly_extension_method_to_replace_the_backofficeusermanager
Added SetBackOfficeUserManager extension method to IUmbracoBuilder
2021-09-08 19:11:52 +02:00
Bjarke Berg
a2bceb0697 Merge pull request #11002 from umbraco/v9/bugfix/fix_issues_when_changing_umbraco_path
Bugfix: Fixed issues when changing UmbracoPath in config
2021-09-08 19:08:11 +02:00
Bjarke Berg
e284e30df5 Fixed issues where we used the global setting UmbracoPath instead of the constant 2021-09-08 18:29:24 +02:00
Bjarke Berg
995595cce1 Merge remote-tracking branch 'origin/v9/dev' into v9/bugfix/fix_issues_when_changing_umbraco_path 2021-09-08 18:17:39 +02:00
Bjarke Berg
774a021ea5 Merge remote-tracking branch 'origin/v9/dev' into v9/dev 2021-09-08 17:50:20 +02:00
Bjarke Berg
6558ed9b0c Changes SchemeForBackOffice to just ensure it is prefixed with "Umbraco.".
https://github.com/umbraco/UmbracoDocs/pull/3438#discussion_r703981003
2021-09-08 17:49:56 +02:00
Bjarke Berg
e5ab0fc084 Merge pull request #10962 from umbraco/v9/task/examine-update
Updates to latest Examine version
2021-09-08 17:45:27 +02:00
Ronald Barendse
26c4fc339f Move extension method classes into separate files 2021-09-08 17:01:34 +02:00
Ronald Barendse
87709f7d35 Fix JS unit tests 2021-09-08 16:58:45 +02:00
Ronald Barendse
e2e9305513 Merge branch 'v8/8.17' into v9/feature/merge_v8.17-rc 2021-09-08 16:43:16 +02:00
Ronald Barendse
0aa545df75 Update parameter order of new AddPropertyGroup overload 2021-09-08 16:24:10 +02:00