Fix logic & make code easier to follow

2019-06-25 11:41:33 +02:00
parent 71d076aba2
commit 1da2c00f0a
1 changed files with 3 additions and 2 deletions
--- a/src/Umbraco.Web/Services/DashboardService.cs
+++ b/src/Umbraco.Web/Services/DashboardService.cs
@@ -104,8 +104,9 @@ namespace Umbraco.Web.Services
                }
            }

-            if (hasAccess || denyRules.Length == 0)
-                return true;
+            // No need to check denyRules if there aren't any, just return current state
+            if (denyRules.Length == 0)
+                return hasAccess;

            // check if this item has any deny arguments, if so check if the user is in one of the denied user groups, if so they will
            // be denied to see it no matter what