yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

initial override corrections

Browse Source
This commit is contained in:
Niels Lyngsø
2024-06-21 10:29:29 +02:00
parent 752965e7d5
commit 1e571bdfa0
2 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Umbraco.Web.UI.Client/src/packages/core/lit-element/lit-element.element.ts
View File

@@ -1,8 +1,6 @@
import { LitElement, property } from '@umbraco-cms/backoffice/external/lit';
import { UmbElementMixin } from '@umbraco-cms/backoffice/element-api';
// TODO: Currently we don't check if the `lang` is registered in the backoffice. We should do that. We can do that by checking if the `lang` is in the `languages` array of the `language` resource and potentially make sure that UmbLocalizationRegistry only loads the localizations and some other mechanism reloads to another language (currently it does both)
/**
* The base class for all Umbraco LitElement elements.
*
@@ -19,7 +17,7 @@ export class UmbLitElement extends UmbElementMixin(LitElement) {
* @example 'ltr'
* @example 'rtl'
*/
@property() dir: 'rtl' | 'ltr' | '' = '';
@property() override dir: 'rtl' | 'ltr' | '' = '';
/**
* The language of the element.
@@ -29,5 +27,5 @@ export class UmbLitElement extends UmbElementMixin(LitElement) {
* @example 'en-us'
* @example 'en'
*/
@property() lang = '';
@property() override lang = '';
}

8
src/Umbraco.Web.UI.Client/src/packages/language/workspace/language/language-workspace.context.ts
View File

@@ -1,6 +1,3 @@
import { UmbLanguageDetailRepository } from '../../repository/index.js';
import type { UmbLanguageDetailModel } from '../../types.js';
import { UmbLanguageWorkspaceEditorElement } from './language-workspace-editor.element.js';
import {
type UmbSubmittableWorkspaceContext,
UmbSubmittableWorkspaceContextBase,
@@ -10,6 +7,9 @@ import {
} from '@umbraco-cms/backoffice/workspace';
import { UmbObjectState } from '@umbraco-cms/backoffice/observable-api';
import type { UmbControllerHost } from '@umbraco-cms/backoffice/controller-api';
import { UmbLanguageDetailRepository } from '../../repository/index.js';
import type { UmbLanguageDetailModel } from '../../types.js';
import { UmbLanguageWorkspaceEditorElement } from './language-workspace-editor.element.js';
export class UmbLanguageWorkspaceContext
extends UmbSubmittableWorkspaceContextBase<UmbLanguageDetailModel>
@@ -27,8 +27,6 @@ export class UmbLanguageWorkspaceContext
#validationErrors = new UmbObjectState<any | undefined>(undefined);
readonly validationErrors = this.#validationErrors.asObservable();
readonly routes = new UmbWorkspaceRouteManager(this);
constructor(host: UmbControllerHost) {
super(host, 'Umb.Workspace.Language');