yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixes issue with OrderByDescending generating invalid SQL (#11673)

Browse Source 
* Fixes issue with OrderByDescending generating invalid SQL

* Update OrderByDexcending with single field for consistecy

Co-authored-by: Michael <michael@crossingpaths.be>
This commit is contained in:
Anders Bjerner
2022-02-28 23:06:59 +01:00
committed by GitHub
parent aba4f02bad
commit 34bfd3a8f3
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Umbraco.Infrastructure/Persistence/NPocoSqlExtensions.cs
View File

@@ -252,7 +252,7 @@ namespace Umbraco.Extensions
/// <returns>The Sql statement.</returns>
public static Sql<ISqlContext> OrderByDescending<TDto>(this Sql<ISqlContext> sql, Expression<Func<TDto, object>> field)
{
return sql.OrderBy("(" + sql.SqlContext.SqlSyntax.GetFieldName(field) + ") DESC");
return sql.OrderByDescending(sql.SqlContext.SqlSyntax.GetFieldName(field));
}
/// <summary>
@@ -268,7 +268,7 @@ namespace Umbraco.Extensions
var columns = fields.Length == 0
? sql.GetColumns<TDto>(withAlias: false)
: fields.Select(x => sqlSyntax.GetFieldName(x)).ToArray();
return sql.OrderBy(columns.Select(x => x + " DESC"));
return sql.OrderByDescending(columns);
}
/// <summary>