yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

V15: Debug missing contexts (#17645)

Browse Source 
* fix: wait a frame before calculating events, which allows the debug callback to "fill up" the instances map

* Revert "fix: wait a frame before calculating events, which allows the debug callback to "fill up" the instances map"

This reverts commit a8a2bdbb053866ee88d35d076dd897bdf0a65826.

* fix: assign the inner object (`event.instances`) directly to a state and perform the "massaging" only when it updates

this ensures that any live changes to the inner object are reflected in the UI
This commit is contained in:
Jacob Overgaard
2024-11-27 12:22:36 +01:00
committed by GitHub
parent 3d1505d4c6
commit 44ec0e66d9
1 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/Umbraco.Web.UI.Client/src/packages/core/debug/debug.element.ts
View File

@@ -3,7 +3,7 @@ import { css, customElement, html, map, nothing, property, state, when } from '@
import { contextData, UmbContextDebugRequest } from '@umbraco-cms/backoffice/context-api';
import { UmbLitElement } from '@umbraco-cms/backoffice/lit-element';
import { UMB_MODAL_MANAGER_CONTEXT } from '@umbraco-cms/backoffice/modal';
import type { UmbDebugContextData, UmbDebugContextItemData } from '@umbraco-cms/backoffice/context-api';
import type { UmbDebugContextItemData } from '@umbraco-cms/backoffice/context-api';
import type { UmbModalManagerContext } from '@umbraco-cms/backoffice/modal';
@customElement('umb-debug')
@@ -15,7 +15,7 @@ export class UmbDebugElement extends UmbLitElement {
dialog = false;
@state()
private _contextData = Array<UmbDebugContextData>();
private _contexts = new Map<any, any>();
@state()
private _debugPaneOpen = false;
@@ -37,11 +37,7 @@ export class UmbDebugElement extends UmbLitElement {
// to the root of <umb-app> which then uses the callback prop
// of this event that has been raised to assign the contexts
// back to this property of the WebComponent
// Massage the data into a simplier array of objects
// from a function in the context-api.
this._contextData = contextData(contexts);
this.requestUpdate('_contextData');
this._contexts = contexts;
}),
);
}
@@ -92,8 +88,9 @@ export class UmbDebugElement extends UmbLitElement {
}
#renderContextAliases() {
const data = contextData(this._contexts);
return html`<div class="events">
${map(this._contextData, (context) => {
${map(data, (context) => {
return html`
<details>
<summary><strong>${context.alias}</strong></summary>