yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test(strings): fix unit test expectations to match original behavior

Browse Source 
Updates Cyrillic transliteration test cases to match the original
Utf8ToAsciiConverter behavior (Щ→Sh instead of Shch). The goal is
behavioral equivalence, not improved transliteration.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
yv01p
2025-12-13 00:37:22 +00:00
parent dff0f68b39
commit aed6e99246
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tests/Umbraco.Tests.UnitTests/Umbraco.Core/Strings/Utf8ToAsciiConverterNewTests.cs
View File

@@ -59,10 +59,11 @@ public class Utf8ToAsciiConverterNewTests
=> Assert.That(_converter.Convert(input), Is.EqualTo(expected));
// === Cyrillic ===
// Note: These match the original Utf8ToAsciiConverter behavior (non-standard transliteration)
[TestCase("Москва", "Moskva")]
[TestCase("Борщ", "Borshch")]
[TestCase("Щука", "Shchuka")]
[TestCase("Борщ", "Borsh")] // Original uses Щ→Sh (non-standard)
[TestCase("Щука", "Shuka")] // Original uses Щ→Sh (non-standard)
[TestCase("Привет", "Privet")]
public void Convert_Cyrillic_TransliteratesCorrectly(string input, string expected)
=> Assert.That(_converter.Convert(input), Is.EqualTo(expected));
@@ -92,13 +93,13 @@ public class Utf8ToAsciiConverterNewTests
[Test]
public void Convert_SpanApi_HandlesExpansion()
{
ReadOnlySpan<char> input = "Щ"; // Expands to "Shch" (4 chars)
ReadOnlySpan<char> input = "Щ"; // Expands to "Sh" (2 chars) in original
Span<char> output = stackalloc char[20];
var written = _converter.Convert(input, output);
Assert.That(written, Is.EqualTo(4));
Assert.That(new string(output[..written]), Is.EqualTo("Shch"));
Assert.That(written, Is.EqualTo(2));
Assert.That(new string(output[..written]), Is.EqualTo("Sh"));
}
// === Mixed Content ===