This commit is contained in:
Niels Lyngsø
2024-08-19 12:33:48 +02:00
parent 2f21c55c93
commit b812f3eaf7
22 changed files with 45 additions and 12 deletions

View File

@@ -4,7 +4,7 @@ import { UMB_MODAL_MANAGER_CONTEXT } from '@umbraco-cms/backoffice/modal';
import { UMB_ACTION_EVENT_CONTEXT } from '@umbraco-cms/backoffice/action';
import { UmbEntityActionBase, UmbRequestReloadStructureForEntityEvent } from '@umbraco-cms/backoffice/entity-action';
export class UmbDuplicateDocumentEntityAction extends UmbEntityActionBase<any> {
export class UmbDuplicateDocumentEntityAction extends UmbEntityActionBase<never> {
override async execute() {
if (!this.args.unique) throw new Error('Unique is not available');
if (!this.args.entityType) throw new Error('Entity Type is not available');

View File

@@ -2,6 +2,7 @@ import { UMB_DUPLICATE_DOCUMENT_MODAL_ALIAS } from './constants.js';
import type { UmbEntityModel } from '@umbraco-cms/backoffice/entity';
import { UmbModalToken } from '@umbraco-cms/backoffice/modal';
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
export interface UmbDuplicateDocumentModalData extends UmbEntityModel {}
export interface UmbDuplicateDocumentModalValue {

View File

@@ -4,6 +4,7 @@ export interface UmbPublicAccessModalData {
unique: string;
}
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
export interface UmbPublicAccessModalValue {}
export const UMB_PUBLIC_ACCESS_MODAL = new UmbModalToken<UmbPublicAccessModalData, UmbPublicAccessModalValue>(

View File

@@ -2,8 +2,10 @@ import type { UmbDocumentVariantPickerData, UmbDocumentVariantPickerValue } from
import { UMB_DOCUMENT_PUBLISH_MODAL_ALIAS } from '../manifests.js';
import { UmbModalToken } from '@umbraco-cms/backoffice/modal';
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
export interface UmbDocumentPublishModalData extends UmbDocumentVariantPickerData {}
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
export interface UmbDocumentPublishModalValue extends UmbDocumentVariantPickerValue {}
export const UMB_DOCUMENT_PUBLISH_MODAL = new UmbModalToken<UmbDocumentPublishModalData, UmbDocumentPublishModalValue>(

View File

@@ -2,6 +2,7 @@ import type { UmbDocumentVariantPickerData, UmbDocumentVariantPickerValue } from
import { UMB_DOCUMENT_PUBLISH_WITH_DESCENDANTS_MODAL_ALIAS } from '../manifests.js';
import { UmbModalToken } from '@umbraco-cms/backoffice/modal';
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
export interface UmbDocumentPublishWithDescendantsModalData extends UmbDocumentVariantPickerData {}
export interface UmbDocumentPublishWithDescendantsModalValue extends UmbDocumentVariantPickerValue {

View File

@@ -1,7 +1,9 @@
import { UMB_ROLLBACK_MODAL_ALIAS } from '../manifests.js';
import { UmbModalToken } from '@umbraco-cms/backoffice/modal';
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
export interface UmbRollbackModalData {}
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
export interface UmbRollbackModalValue {}
export const UMB_ROLLBACK_MODAL = new UmbModalToken<UmbRollbackModalData, UmbRollbackModalValue>(

View File

@@ -2,8 +2,10 @@ import type { UmbDocumentVariantPickerData, UmbDocumentVariantPickerValue } from
import { UMB_DOCUMENT_SAVE_MODAL_ALIAS } from '../manifests.js';
import { UmbModalToken } from '@umbraco-cms/backoffice/modal';
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
export interface UmbDocumentSaveModalData extends UmbDocumentVariantPickerData {}
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
export interface UmbDocumentSaveModalValue extends UmbDocumentVariantPickerValue {}
export const UMB_DOCUMENT_SAVE_MODAL = new UmbModalToken<UmbDocumentSaveModalData, UmbDocumentSaveModalValue>(

View File

@@ -8,6 +8,7 @@ export interface UmbDocumentScheduleSelectionModel {
schedule?: ScheduleRequestModel | null;
}
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
export interface UmbDocumentScheduleModalData extends UmbDocumentVariantPickerData {}
export interface UmbDocumentScheduleModalValue {

View File

@@ -6,6 +6,7 @@ export interface UmbDocumentUnpublishModalData extends UmbDocumentVariantPickerD
documentUnique?: string;
}
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
export interface UmbDocumentUnpublishModalValue extends UmbDocumentVariantPickerValue {}
export const UMB_DOCUMENT_UNPUBLISH_MODAL = new UmbModalToken<

View File

@@ -1,6 +1,8 @@
import type { UmbDocumentTreeItemModel } from '../../tree/index.js';
import type { UmbTreeRootModel } from '@umbraco-cms/backoffice/tree';
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
export interface UmbDocumentRecycleBinTreeItemModel extends UmbDocumentTreeItemModel {}
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
export interface UmbDocumentRecycleBinTreeRootModel extends UmbTreeRootModel {}

View File

@@ -36,6 +36,8 @@ export interface UmbDocumentValueModel<ValueType = unknown> {
value: ValueType;
}
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
export interface UmbDocumentVariantOptionModel extends UmbVariantOptionModel<UmbDocumentVariantModel> {}
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
export interface UmbDocumentVariantPublishModel extends UmbVariantPublishModel {}

View File

@@ -133,7 +133,7 @@ export class UmbInputDocumentGranularUserPermissionElement extends UUIFormContro
try {
const value = await this.#entityUserPermissionModalContext?.onSubmit();
return value?.allowedVerbs;
} catch (error) {
} catch {
throw new Error();
}
}

View File

@@ -22,7 +22,11 @@ export class UmbDocumentSaveAndPublishWorkspaceAction extends UmbWorkspaceAction
allOf: [UMB_USER_PERMISSION_DOCUMENT_UPDATE, UMB_USER_PERMISSION_DOCUMENT_PUBLISH],
},
onChange: () => {
condition.permitted ? this.enable() : this.disable();
if (condition.permitted) {
this.enable();
} else {
this.disable();
}
},
});
}

View File

@@ -25,7 +25,11 @@ export class UmbDocumentSaveWorkspaceAction extends UmbSubmitWorkspaceAction {
oneOf: [UMB_USER_PERMISSION_DOCUMENT_CREATE, UMB_USER_PERMISSION_DOCUMENT_UPDATE],
},
onChange: () => {
condition.permitted ? this.enable() : this.disable();
if (condition.permitted) {
this.enable();
} else {
this.disable();
}
},
});
}

View File

@@ -214,7 +214,7 @@ export class UmbLogViewerWorkspaceContext extends UmbControllerBase implements U
try {
this.#savedSearches.update({ items: [...previousSavedSearches, { name, query }] });
await this.#repository.saveSearch({ name, query });
} catch (err) {
} catch {
this.#savedSearches.update({ items: previousSavedSearches });
}
}
@@ -224,7 +224,7 @@ export class UmbLogViewerWorkspaceContext extends UmbControllerBase implements U
try {
this.#savedSearches.update({ items: previousSavedSearches.filter((search) => search.name !== name) });
await this.#repository.removeSearch({ name });
} catch (err) {
} catch {
this.#savedSearches.update({ items: previousSavedSearches });
}
}

View File

@@ -43,7 +43,11 @@ export class UmbLogViewerMessageElement extends UmbLitElement {
protected override updated(_changedProperties: PropertyValueMap<any> | Map<PropertyKey, unknown>): void {
if (_changedProperties.has('open')) {
this.open ? this.details.setAttribute('open', 'true') : this.details.removeAttribute('open');
if (this.open) {
this.details.setAttribute('open', 'true');
} else {
this.details.removeAttribute('open');
}
}
}

View File

@@ -7,6 +7,7 @@ export interface UmbContextSaveSearchModalData {
query: string;
}
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
export interface UmbContextSaveSearchModalValue extends SavedLogSearchResponseModel {}
@customElement('umb-log-viewer-save-search-modal')

View File

@@ -10,8 +10,11 @@ export interface UmbMediaTypeDetailModel extends UmbContentTypeModel {
entityType: UmbMediaTypeEntityType;
}
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
export interface UmbMediaTypeAvailableCompositionRequestModel extends UmbContentTypeAvailableCompositionRequestModel {}
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
export interface UmbMediaTypeCompositionCompatibleModel extends UmbContentTypeCompositionCompatibleModel {}
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
export interface UmbMediaTypeCompositionReferenceModel extends UmbContentTypeCompositionReferenceModel {}

View File

@@ -1,4 +1,5 @@
import type { UmbMediaAuditLogType } from './utils/index.js';
import type { UmbAuditLogModel } from '@umbraco-cms/backoffice/audit-log';
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
export interface UmbMediaAuditLogModel extends UmbAuditLogModel<UmbMediaAuditLogType> {}

View File

@@ -71,6 +71,7 @@ export class UmbDropzoneManager extends UmbControllerBase {
* Allows the user to pick a media type option if multiple types are allowed.
* @param files
* @param parentUnique
* @returns Promise<void>
*/
public async createFilesAsMedia(files: Array<File>, parentUnique: string | null) {
if (!files.length) return;
@@ -118,11 +119,8 @@ export class UmbDropzoneManager extends UmbControllerBase {
}
notAllowedFiles.forEach((file) => {
try {
throw new Error(`File ${file.name} of type ${file.type} is not allowed here.`);
} catch (e) {
undefined;
}
// TODO: It seems like some implementation(user feedback) is missing here? [NL]
console.error(`File ${file.name} of type ${file.type} is not allowed here.`);
});
if (!uploadableFiles.length) return;

View File

@@ -8,6 +8,7 @@ export interface UmbMediaCreateOptionsModalData {
} | null;
}
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
export interface UmbMediaCreateOptionsModalValue {}
export const UMB_MEDIA_CREATE_OPTIONS_MODAL = new UmbModalToken<

View File

@@ -1,6 +1,8 @@
import type { UmbMediaTreeItemModel } from '../../tree/index.js';
import type { UmbTreeRootModel } from '@umbraco-cms/backoffice/tree';
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
export interface UmbMediaRecycleBinTreeItemModel extends UmbMediaTreeItemModel {}
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
export interface UmbMediaRecycleBinTreeRootModel extends UmbTreeRootModel {}