yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

add todos to clean up the tree repository interface

Browse Source
This commit is contained in:
Mads Rasmussen
2023-11-13 15:45:18 +01:00
parent e963944f29
commit ea0d7fe041
1 changed files with 14 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/Umbraco.Web.UI.Client/src/packages/core/repository/tree-repository.interface.ts
View File

@@ -13,17 +13,26 @@ export interface UmbTreeRepository<
error?: ProblemDetails;
}>;
requestTreeItemsOf: (parentUnique: string | null) => Promise<{
data?: UmbPagedData<TreeItemType>;
error?: ProblemDetails;
asObservable?: () => Observable<TreeItemType[]>;
}>;
treeItemsOf: (parentUnique: string | null) => Promise<Observable<TreeItemType[]>>;
/* TODO: remove this. It is not used client side.
Logic to call the root endpoint should be in the data source
because it is a server decision to split them
*/
requestRootTreeItems: () => Promise<{
data?: UmbPagedData<TreeItemType>;
error?: ProblemDetails;
asObservable?: () => Observable<TreeItemType[]>;
}>;
requestTreeItemsOf: (parentUnique: string | null) => Promise<{
data?: UmbPagedData<TreeItemType>;
error?: ProblemDetails;
asObservable?: () => Observable<TreeItemType[]>;
}>;
// TODO: remove
rootTreeItems: () => Promise<Observable<TreeItemType[]>>;
// TODO: remove this when all repositories are migrated to the new interface items interface
requestItemsLegacy?: (uniques: string[]) => Promise<{
@@ -32,10 +41,6 @@ export interface UmbTreeRepository<
asObservable?: () => Observable<any[]>;
}>;
rootTreeItems: () => Promise<Observable<TreeItemType[]>>;
treeItemsOf: (parentUnique: string | null) => Promise<Observable<TreeItemType[]>>;
// TODO: remove this when all repositories are migrated to the new items interface
itemsLegacy?: (uniques: string[]) => Promise<Observable<any[]>>;
}