Commit Graph

39440 Commits

Author SHA1 Message Date
Elitsa Marinovska
e9b697b0c2 Cleanup 2021-08-17 13:10:13 +02:00
Elitsa Marinovska
d8b3a1bbe5 Get rid of some more duplicate code 2021-08-17 13:09:25 +02:00
Zeegaan
285c9c92b5 Fixed duplications 2021-08-17 11:41:28 +02:00
Zeegaan
6c545a29c7 Fixed missing null checks 2021-08-17 11:33:51 +02:00
Nikolaj Geisle
dbe38968de Update src/Umbraco.Core/Templates/UmbracoComponentRenderer.cs
Co-authored-by: Elitsa Marinovska <21998037+elit0451@users.noreply.github.com>
2021-08-17 11:31:03 +02:00
Zeegaan
255e0d4134 Updated summaries 2021-08-17 11:20:17 +02:00
Zeegaan
d9a7727175 implemented checking if "_httpContextAccessor" is null 2021-08-17 10:21:00 +02:00
Zeegaan
d51fed4f6d Fixed UmbracoHelperAccessor to do a null check 2021-08-17 08:34:01 +02:00
Zeegaan
4e2d9159f4 Merged v9/dev into this branch 2021-08-16 12:43:28 +02:00
Zeegaan
95fd1f57ba Added missing using 2021-08-16 12:39:23 +02:00
Zeegaan
61f952bd70 Changed the UmbracoContextAccessor checks with extension methods to lessen duplicate code 2021-08-16 12:36:50 +02:00
Mole
5d5ee574c8 Merge pull request #10865 from umbraco/v9/task/removed-VaritaionContextAccessor-from-IUmbracoContext
v9: Removed VariationContextAccessor from IUmbracoContext
2021-08-16 10:44:20 +02:00
Zeegaan
c5be9129bb Merge required 2 updates to use the new TryGetUmbracoContext 2021-08-16 10:42:26 +02:00
Zeegaan
33ab3a32ec Merged v9/dev into this branch 2021-08-16 10:41:36 +02:00
Zeegaan
cca7c379ae Implemented an extension method to lessen duplication of code 2021-08-16 10:31:11 +02:00
Zeegaan
2a03c7dfd3 Removed CultureAccessor from test 2021-08-16 08:54:28 +02:00
Zeegaan
3c4cefb17d Removed VariationContextAccessor from IUmbracoContext 2021-08-16 08:43:13 +02:00
Bjarke Berg
3c6efa6cb5 Merge pull request #10787 from umbraco/v9/bugfix/member_validation_doesnt_update_properly
v9: Fixed a bug where validation didnt update properly
2021-08-13 19:19:37 +02:00
Bjarke Berg
cf78027b84 Merge pull request #10850 from umbraco/v9/bugfix/user-roles-fail-if-0
v9: If you didnt have a member group, restricting acces to the public would always lead to error page
2021-08-13 19:15:43 +02:00
Bjarke Berg
8c42d563bd Updated unittest to match real usecase 2021-08-13 18:51:06 +02:00
Bjarke Berg
8e2044ad4e Revert "Removed UnitTest"
This reverts commit 18d670bc20.
2021-08-13 18:30:09 +02:00
Paul Johnson
774e174b87 Remove duplicate project references in Umbraco.Examine.Lucene.csproj 2021-08-13 14:34:52 +01:00
Zeegaan
18d670bc20 Removed UnitTest 2021-08-13 12:17:20 +02:00
Zeegaan
683170b04e Removed Unneccesary if check 2021-08-13 10:51:50 +02:00
Paul Johnson
afe3f5bc38 Merge pull request #10849 from umbraco/v9/feature/improve-pipelines-test-setup
Build sln before running tests.
2021-08-13 09:46:16 +01:00
Paul Johnson
5aad18b99a Build sln before running tests.
Should prevent more OS related broken builds e.g. project files with case sensitivity issues.
2021-08-13 09:21:10 +01:00
Nikolaj Geisle
21c762d7de Merge pull request #10838 from umbraco/v9/bugfix/AB13223-fix-absolute-url-provider-mode
V9: Fix RedirectToCurrentUmbracoPage when UrlProviderMode is set to "Absolute"
2021-08-13 09:12:42 +02:00
Shannon
c92e1beaa0 Better debugging when working with external login providers 2021-08-12 15:50:47 -06:00
Kenny Nielsen
e4a2fc2736 Only encode text once
Html.ReplaceLineBreaks calls WebUtility.HtmlEncode internally, so the text gets encoded by this method.

As far as I know, WebUtility.HtmlEncode and HttpUtility.HtmlEncode produces the same result (unlike WebUtility.UrlEncode and HttpUtility.UrlEncode which produces different results; see https://edi.wang/post/2018/11/25/netcore-webutility-urlencode-httputility-urlencode), so it should be safe to omit HttpUtility.HtmlEncode here.
2021-08-12 16:16:48 +02:00
Laura Neto
7710409be8 Set isMainPage to true on TemplateRenderer.ExecuteTemplateRendering (#10684)
* Set isMainPage to true on TemplateRenderer.ExecuteTemplateRendering (#10683)

* Added comment

* Tweak comment for clarity

Co-authored-by: Paul Johnson <pmj@umbraco.com>
2021-08-12 11:09:21 +01:00
Elitsa Marinovska
185cebb490 Adding a check for when the UrlProviderMode is set to Absolute 2021-08-12 12:08:39 +03:00
Bjarke Berg
6085e03600 Merge remote-tracking branch 'origin/v9/dev' into v9/dev 2021-08-12 11:03:32 +02:00
Bjarke Berg
42255a8dc3 Removed connection string 2021-08-12 11:03:14 +02:00
Bjarke Berg
40b9109f65 Merge pull request #10834 from umbraco/v9/remove-system.configuration
V9 Remove System.Configuration
2021-08-12 09:02:48 +02:00
Elitsa Marinovska
6097faa906 Remove connection string from appsettings.json 2021-08-12 09:43:29 +03:00
Bjarke Berg
765f650d08 Merge pull request #10835 from umbraco/v9/feature/merge_v8_11082021
Merge V8.16RC into V9 11-08-2021
2021-08-11 20:13:58 +02:00
Bjarke Berg
d775de5ddd Fixed issue after merge 2021-08-11 19:38:23 +02:00
Bjarke Berg
2baa1abfc4 Merge remote-tracking branch 'origin/v8/8.16' into v9/feature/merge_v8_11082021
# Conflicts:
#	.github/CONTRIBUTING.md
#	build/NuSpecs/UmbracoCms.Core.nuspec
#	build/NuSpecs/UmbracoCms.Web.nuspec
#	build/NuSpecs/UmbracoCms.nuspec
#	src/SolutionInfo.cs
#	src/Umbraco.Core/Cache/AppCaches.cs
#	src/Umbraco.Core/Cache/AppPolicedCacheDictionary.cs
#	src/Umbraco.Core/Cache/DeepCloneAppCache.cs
#	src/Umbraco.Core/Cache/WebCachingAppCache.cs
#	src/Umbraco.Core/CompositionExtensions.cs
#	src/Umbraco.Core/Models/Identity/BackOfficeIdentityUser.cs
#	src/Umbraco.Core/Models/PropertyGroupCollection.cs
#	src/Umbraco.Core/Models/PropertyTypeCollection.cs
#	src/Umbraco.Core/Persistence/Repositories/Implement/ExternalLoginRepository.cs
#	src/Umbraco.Core/ReadLock.cs
#	src/Umbraco.Core/Routing/SiteDomainMapper.cs
#	src/Umbraco.Core/UpgradeableReadLock.cs
#	src/Umbraco.Core/WriteLock.cs
#	src/Umbraco.Examine/ExamineExtensions.cs
#	src/Umbraco.Infrastructure/Examine/UmbracoFieldDefinitionCollection.cs
#	src/Umbraco.Infrastructure/Persistence/Dtos/ContentTypeDto.cs
#	src/Umbraco.Infrastructure/Persistence/Dtos/DictionaryDto.cs
#	src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MemberGroupRepository.cs
#	src/Umbraco.Infrastructure/Persistence/Repositories/Implement/TemplateRepository.cs
#	src/Umbraco.Infrastructure/Persistence/Repositories/Implement/UserRepository.cs
#	src/Umbraco.Infrastructure/Services/IdKeyMap.cs
#	src/Umbraco.Infrastructure/Services/Implement/ContentService.cs
#	src/Umbraco.ModelsBuilder.Embedded/PureLiveModelFactory.cs
#	src/Umbraco.Tests/App.config
#	src/Umbraco.Web.BackOffice/Controllers/EntityController.cs
#	src/Umbraco.Web.UI.Client/package.json
#	src/Umbraco.Web.UI.NetCore/umbraco/config/lang/da.xml
#	src/Umbraco.Web.UI.NetCore/umbraco/config/lang/en.xml
#	src/Umbraco.Web.UI.NetCore/umbraco/config/lang/en_us.xml
#	src/Umbraco.Web.UI/Umbraco.Web.UI.csproj
#	src/Umbraco.Web.UI/Umbraco/config/lang/cy.xml
#	src/Umbraco.Web.UI/web.Template.config
#	src/Umbraco.Web/CacheHelperExtensions.cs
#	src/Umbraco.Web/Editors/RelationTypeController.cs
#	src/Umbraco.Web/Logging/WebProfilerProvider.cs
#	src/Umbraco.Web/Models/Mapping/MemberMapDefinition.cs
#	src/Umbraco.Web/PublishedCache/NuCache/MemberCache.cs
#	src/Umbraco.Web/Routing/ContentFinderByConfigured404.cs
#	src/Umbraco.Web/Routing/NotFoundHandlerHelper.cs
#	src/Umbraco.Web/Security/BackOfficeUserManager.cs
#	src/Umbraco.Web/Umbraco.Web.csproj
2021-08-11 19:11:35 +02:00
Bjarke Berg
c5e882680b Fixed issue with model state marked as invalid on the entire model, where we handle it for each item separately 2021-08-11 15:43:41 +02:00
Warren Buckley
f794f63884 Use ToSemanticStringWithoutBuild() extension method 2021-08-11 14:20:58 +01:00
Warren Buckley
042371a99a Merge branch 'v9/dev' into v9/remove-system.configuration 2021-08-11 14:08:52 +01:00
Bjarke Berg
dfa76af4d6 Merge remote-tracking branch 'origin/v9/dev' into v9/dev 2021-08-11 14:50:56 +02:00
Bjarke Berg
c5752b5db5 Revert "Fixed issue with saving content when having an empty variant. Aligned codebase with how it is in v8"
This reverts commit 5ae0b64b36.
2021-08-11 14:50:39 +02:00
Nikolaj Geisle
6be555f85a Merge pull request #10832 from umbraco/v9/bugfix/cached_partial_did_not_materialize_before_caching
Fixed issue with CachedPartial that cached an unmaterialized value
2021-08-11 14:42:25 +02:00
Warren Buckley
f351cc15d5 Fix up TestData to not use ConfigManager but to get Version from injected IUmbracoVersion in the view 2021-08-11 13:33:53 +01:00
Bjarke Berg
805a228e6b Merge remote-tracking branch 'origin/v9/dev' into v9/dev 2021-08-11 14:32:35 +02:00
Bjarke Berg
5ae0b64b36 Fixed issue with saving content when having an empty variant. Aligned codebase with how it is in v8 2021-08-11 14:32:08 +02:00
Warren Buckley
f09ec194fe Remove System.Configuration from tests 2021-08-11 13:27:28 +01:00
Warren Buckley
485730b776 Use TestData Options/Settings as opposed to ConfigManager 2021-08-11 13:27:03 +01:00
Warren Buckley
ec15f20fdf Replace excetion type from System.Configuration 2021-08-11 13:26:28 +01:00